Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: port source map sorting logic from chromium #31927

Closed
wants to merge 2 commits into from
Closed

module: port source map sorting logic from chromium #31927

wants to merge 2 commits into from

Commits on Feb 24, 2020

  1. module: port source map sorting logic from chromium 

    Digging in to the delta between V8's source map library, and chromium's
the most significant difference that jumped out at me was that we were
failing to sort generated columns. Since negative offsets are not
restricted in the spec, this can lead to bugs.

fixes: nodejs#31286
    @bcoe
    bcoe committed Feb 24, 2020
    Copy the full SHA
    584bdd8 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. chore: address code review

    @bcoe
    bcoe committed Feb 27, 2020
    Copy the full SHA
    3e6b697 View commit details
    Browse the repository at this point in the history