Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add missing comma in node.gyp #31959

Merged
merged 1 commit into from Feb 27, 2020
Merged

build: add missing comma in node.gyp #31959

merged 1 commit into from Feb 27, 2020

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 26, 2020

This commit adds a missing comma for consistency with the surrounding lines.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Feb 26, 2020
bnoordhuis
bnoordhuis approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not just consistency. GYP works like python in that it concatenates strings unless separated by a comma.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29400/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 27, 2020 •
edited by cjihrig

CI: https://ci.nodejs.org/job/node-test-pull-request/29402/ 💛

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 27, 2020
@gengjiawen
Copy link
Member

gengjiawen commented Feb 27, 2020 •
edited

Can we fast track this ? Code navigation not working due to this.

Found MSVS version 15.0
configure  --dest-cpu=x64
Node.js configure: Found Python 2.7.17...
Warning: Missing input files:
src\large_pages\node_large_page.hsrc\memory_tracker.h
tools\msvs\genfiles\node_etw_provider.rc
tools\msvs\genfiles\node_etw_provider.h

@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 27, 2020

This has the approvals, CI run, etc. Please 👍 this comment to approve fast tracking as @gengjiawen requests.

@cjihrig
build: add missing comma in node.gyp
a29b6cd 
This commit adds a missing comma for consistency with the
surrounding lines.

PR-URL: nodejs#31959
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@cjihrig cjihrig added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 27, 2020
@cjihrig cjihrig merged commit a29b6cd into nodejs:master Feb 27, 2020
@cjihrig cjihrig deleted the comma branch February 27, 2020 14:58
codebytere pushed a commit that referenced this pull request Feb 27, 2020
@cjihrig @codebytere
build: add missing comma in node.gyp
ca44071 
This commit adds a missing comma for consistency with the
surrounding lines.

PR-URL: #31959
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@codebytere codebytere mentioned this pull request Feb 29, 2020
Merged
@targos
Copy link
Member

targos commented Apr 18, 2020

Depends on the large pages change to land on v12.x

@targos targos removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x labels Apr 25, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@cjihrig @targos
build: add missing comma in node.gyp
6c3897e 
This commit adds a missing comma for consistency with the
surrounding lines.

PR-URL: nodejs#31959
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@cjihrig @targos
build: add missing comma in node.gyp
e765d59 
This commit adds a missing comma for consistency with the
surrounding lines.

PR-URL: #31959
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@targos targos mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@cjihrig @nodejs-github-bot @gengjiawen @targos @bnoordhuis @ChALkeR @addaleax @lpinca @richardlau