Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v13.x backport] stream: support passing generator functions into pipeline() #31975

Closed
wants to merge 3 commits into from
Closed

[v13.x backport] stream: support passing generator functions into pipeline() #31975

wants to merge 3 commits into from

Commits on Feb 27, 2020

  1. stream: support passing generator functions into pipeline() 

    Backport-PR-URL: nodejs#31975
PR-URL: nodejs#31223
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @ronag
    ronag committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    8af1387 View commit details
    Browse the repository at this point in the history

  2. stream: fix broken pipeline error propagation 

    If the destination was an async function any
error thrown from that function would be swallowed.

Backport-PR-URL: nodejs#31975
PR-URL: nodejs#31835
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    @ronag
    ronag committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    21a0dd0 View commit details
    Browse the repository at this point in the history

  3. stream: ensure pipeline always destroys streams 

    There was an edge case where an incorrect assumption was made
in regardos whether eos/finished means that the stream is
actually destroyed or not.

Backport-PR-URL: nodejs#31975
PR-URL: nodejs#31940
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @ronag
    ronag committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    23011b9 View commit details
    Browse the repository at this point in the history