Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13.10.0 proposal #32027

Merged
merged 91 commits into from Mar 4, 2020
Merged

v13.10.0 proposal #32027

merged 91 commits into from Mar 4, 2020

Commits on Feb 27, 2020

  1. doc: guide - using valgrind to debug memory leaks

    Add doc for using valgrind to debug native
    memory leaks.
    
    Started writing this up as part of an effort
    in the Diagnostic WG but think it's better
    to have it in the core guides and then be referenced
    by the docs in the Diagnostic WG repo.
    
    For more details on the Diagnostic WG effort see
    nodejs/diagnostics#254 (comment)
    This guide is related to `/step3 - using_native_tools.md`
    
    PR-URL: #31501
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mhdawson authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    db291aa View commit details
    Browse the repository at this point in the history
  2. src: prefer 3-argument Array::New()

    This is nicer, because:
    
    1. It reduces overall code size,
    2. It’s faster, because `Object::Set()` calls are relatively slow, and
    3. It helps avoid invalid `.Check()`/`.FromJust()` calls.
    
    PR-URL: #31775
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    addaleax authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    57302f8 View commit details
    Browse the repository at this point in the history
  3. doc: claim ABI version 82 for Electron 10

    PR-URL: #31778
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    MarshallOfSound authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    eb2dce8 View commit details
    Browse the repository at this point in the history
  4. worker: unroll file extension regexp

    Refs: #31662 (comment)
    
    PR-URL: #31779
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    addaleax authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    f87ac90 View commit details
    Browse the repository at this point in the history
  5. doc: fix typos in doc/api/https.md

    PR-URL: #31793
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Jeff-Tian authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    9e4aad7 View commit details
    Browse the repository at this point in the history
  6. doc: move @Fishrock123 to a previous releaser

    I have not done a release in well over a year, maybe even two.
    
    I also don't really plan to do more,
    as Node.js releases are very tedious.
    
    PR-URL: #31725
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Fishrock123 authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    b177bba View commit details
    Browse the repository at this point in the history
  7. doc: move @Fishrock123 to TSC Emeriti

    It was a good run. Almost 5 years.
    
    I haven't really been involved in the last 3+? months though,
    so it's time I call it and 'retire'.
    
    I think it is unlikely that I'll be on the TSC again,
    as node is unfortunately becoming increasingly
    disinteresting (& frustrating) to me.
    
    (So long and thanks for all the fish!)
    
    PR-URL: #31725
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Fishrock123 authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    7f4d6ee View commit details
    Browse the repository at this point in the history
  8. doc: pronouns for @Fishrock123

    might as well while I'm at it
    
    feels a bit weird being the first person on this list
    with '/they' but I guess someone's gota do it
    
    PR-URL: #31725
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Fishrock123 authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    b071758 View commit details
    Browse the repository at this point in the history
  9. doc: move gireeshpunathil to TSC emeritus

    PR-URL: #31770
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    gireeshpunathil authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    f952605 View commit details
    Browse the repository at this point in the history
  10. test: add known issue test for sync writable callback

    If the write callbacks are invoked synchronously with an
    error, onwriteError would cause the error event to be
    emitted synchronously, making it impossible to attach
    an error handler after the call that triggered it.
    
    PR-URL: #31756
    Refs: nodejs/quic@b0d469c
    Refs: nodejs/quic#341
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    jasnell authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    60c71dc View commit details
    Browse the repository at this point in the history
  11. doc: reword possessive form of Node.js in debugger.md

    Throughout the docs, we sometimes write the possessive of _Node.js_ as
    _Node.js'_ and other times as _Node.js's_. The former conforms with some
    generally accepted style guides (e.g., Associated Press Stylebook) while
    the latter complies with others (e.g., Chicago Manual of Style).
    
    Since there is no clear authoritative answer as to which form is
    correct, and since (at least to me) both are visually jarring and
    sometimes cause a pause to understand, I'd like to reword things to
    eliminate the possessive form where possible.
    
    This is one of those examples.
    
    PR-URL: #31748
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    3969af4 View commit details
    Browse the repository at this point in the history
  12. doc: reword possessive form of Node.js in process.md

    Throughout the docs, we sometimes write the possessive of _Node.js_ as
    _Node.js'_ and other times as _Node.js's_. The former conforms with some
    generally accepted style guides (e.g., Associated Press Stylebook) while
    the latter complies with others (e.g., Chicago Manual of Style).
    
    Since there is no clear authoritative answer as to which form is
    correct, and since (at least to me) both are visually jarring and
    sometimes cause a pause to understand, I'd like to reword things to
    eliminate the possessive form where possible.
    
    This is one of those examples.
    
    PR-URL: #31748
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    cb210e6 View commit details
    Browse the repository at this point in the history
  13. doc: reword possessive form of Node.js in http.md

    Throughout the docs, we sometimes write the possessive of _Node.js_ as
    _Node.js'_ and other times as _Node.js's_. The former conforms with some
    generally accepted style guides (e.g., Associated Press Stylebook) while
    the latter complies with others (e.g., Chicago Manual of Style).
    
    Since there is no clear authoritative answer as to which form is
    correct, and since (at least to me) both are visually jarring and
    sometimes cause a pause to understand, I'd like to reword things to
    eliminate the possessive form where possible.
    
    This is one of those examples.
    
    PR-URL: #31748
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    3eaf377 View commit details
    Browse the repository at this point in the history
  14. doc: reword possessive form of Node.js in adding-new-napi-api.md

    Throughout the docs, we sometimes write the possessive of _Node.js_ as
    _Node.js'_ and other times as _Node.js's_. The former conforms with some
    generally accepted style guides (e.g., Associated Press Stylebook) while
    the latter complies with others (e.g., Chicago Manual of Style).
    
    Since there is no clear authoritative answer as to which form is
    correct, and since (at least to me) both are visually jarring and
    sometimes cause a pause to understand, I'd like to reword things to
    eliminate the possessive form where possible.
    
    This is one of those examples.
    
    PR-URL: #31748
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    672f76d View commit details
    Browse the repository at this point in the history
  15. src: inform callback scopes about exceptions in HTTP parser

    Refs: 4aca277
    Refs: #30236
    Fixes: #31796
    
    PR-URL: #31801
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    addaleax authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    98d262e View commit details
    Browse the repository at this point in the history
  16. test: remove common.PORT from test-net-timeout

    Switch test-net-timeout from common.PORT to a port assigned by the
    operating system.
    
    PR-URL: #31749
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    724bf31 View commit details
    Browse the repository at this point in the history
  17. test: remove common.PORT from test-net-throttle

    Switch test-net-throttle from common.PORT to a port assigned by the
    operating system.
    
    PR-URL: #31749
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    e76ac1d View commit details
    Browse the repository at this point in the history
  18. test: remove common.PORT from test-tls-server-large-request

    Switch test-tls-server-large-request from common.PORT to a port assigned
    by the operating system.
    
    PR-URL: #31749
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    3fbd5ab View commit details
    Browse the repository at this point in the history
  19. test: remove common.PORT from test-net-pause

    Switch test-net-pause from common.PORT to a port assigned by the
    operating system.
    
    PR-URL: #31749
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    87e9014 View commit details
    Browse the repository at this point in the history
  20. module: package "exports" error refinements

    PR-URL: #31625
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    guybedford authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    bbb6cc7 View commit details
    Browse the repository at this point in the history
  21. http2: make compat finished match http/1

    finished should true directly after end().
    
    PR-URL: #24347
    Refs: #24743
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ronag authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    9079bb4 View commit details
    Browse the repository at this point in the history
  22. doc: fix notable changes for v13.9.0

    PR-URL: #31857
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    3438937 View commit details
    Browse the repository at this point in the history
  23. meta: move eljefedelrodeodeljefe to emeritus

    eljefedelrodeodeljefe confirmed in email that moving to emeritus was
    fine at this time.
    
    PR-URL: #31735
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    94a471a View commit details
    Browse the repository at this point in the history
  24. vm: lazily initialize primordials for vm contexts

    Lazily initialize primordials when cross-context support for
    builtins is needed to fix the performance regression in context
    creation.
    
    PR-URL: #31738
    Fixes: #29842
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    joyeecheung authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    a86cb0e View commit details
    Browse the repository at this point in the history
  25. worker: emit runtime error on loop creation failure

    Instead of hard asserting throw a runtime error,
    that is more consumable.
    
    Fixes: #31614
    
    PR-URL: #31621
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    HarshithaKP authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    f2389eb View commit details
    Browse the repository at this point in the history
  26. test: remove common.PORT from test-net-write-callbacks.js

    Switch test-net-write-callbacks.js from common.PORT to a port assigned
    by the operating system.
    
    PR-URL: #31839
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    1933efa View commit details
    Browse the repository at this point in the history
  27. test: remove flaky designation for test-net-connect-options-port

    Closes: #23207
    
    PR-URL: #31841
    Fixes: #23207
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    7d5776e View commit details
    Browse the repository at this point in the history
  28. tools: update lint-md task to lint for possessives of Node.js

    Add a markdown lint rule to prohibit "Node.js'" and "Node.js's".
    Instead, of "Node.js' module system", use "the Node.js module system".
    
    Refs: #31748 (comment)
    
    PR-URL: #31862
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    f858f23 View commit details
    Browse the repository at this point in the history
  29. doc: add note about ssh key to releases

    PR-URL: #31856
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    091b4bf View commit details
    Browse the repository at this point in the history
  30. tools: sync gyp code base with node-gyp repo

    PR-URL: #30563
    Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    targos authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    79b1f04 View commit details
    Browse the repository at this point in the history
  31. meta: move julianduque to emeritus

    julianduque confirmed in email that they can be moved to emeritus.
    
    PR-URL: #31863
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    61a0d8b View commit details
    Browse the repository at this point in the history
  32. crypto: fix ieee-p1363 for createVerify

    Fixes: #31866
    
    PR-URL: #31876
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    d0e94fc View commit details
    Browse the repository at this point in the history
  33. doc: fix anchor for ERR_TLS_INVALID_CONTEXT

    PR-URL: #31915
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    tniessen authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    2046652 View commit details
    Browse the repository at this point in the history
  34. tls: expose SSL_export_keying_material

    Fixes: #31802
    
    PR-URL: #31814
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    simllll authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    acb3aff View commit details
    Browse the repository at this point in the history
  35. doc,crypto: re-document oaepLabel option

    Erroneously removed in #29516.
    
    Fixes: #31810
    Refs: #29516
    
    PR-URL: #31825
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    bnoordhuis authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    aa16d80 View commit details
    Browse the repository at this point in the history
  36. test: remove common.PORT from assorted pummel tests

    Use port "0" for an OS-provided open port instead of common.PORT.
    
    PR-URL: #31897
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    4fe9e04 View commit details
    Browse the repository at this point in the history
  37. cli: --perf-prof only works on Linux

    PR-URL: #31892
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    4dffd04 View commit details
    Browse the repository at this point in the history
  38. async_hooks: introduce async-context API

    Adding AsyncLocalStorage class to async_hooks
     module.
    This API provide a simple CLS-like set
    of features.
    
    Co-authored-by: Andrey Pechkurov <apechkurov@gmail.com>
    
    PR-URL: #26540
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    vdeturckheim authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    877ab97 View commit details
    Browse the repository at this point in the history
  39. doc: update assert.rejects() docs with a validation function example

    Spawned from my own struggle to use in https://gitlab.com/gitlab-org/gitter/webapp/merge_requests/1702#note_268452483
    
    PR-URL: #31271
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    MadLittleMods authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    15cc9b0 View commit details
    Browse the repository at this point in the history
  40. src: move BaseObject subclass dtors/ctors out of node_crypto.h

    Originally landed in the QUIC repo
    
    Move constructor and destructors for subclasses of `BaseObject`
    from node_crypto.h to node_crypto.cc. This removes the need to
    include base_object-inl.h when using node_crypto.h in some cases.
    
    Original review metadata:
    
    ```
      PR-URL: nodejs/quic#220
      Reviewed-By: Anna Henningsen <anna@addaleax.net>
      Reviewed-By: James M Snell <jasnell@gmail.com>
    ```
    
    PR-URL: #31872
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    addaleax authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    88ccb44 View commit details
    Browse the repository at this point in the history
  41. src: allow unique_ptrs with custom deleter in memory tracker

    Originally landed in the QUIC repo
    
    Original review metadata:
    
    ```
      PR-URL: nodejs/quic#145
      Reviewed-By: James M Snell <jasnell@gmail.com>
    ```
    
    PR-URL: #31870
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    addaleax authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    8fa6373 View commit details
    Browse the repository at this point in the history
  42. doc: update releases guide re pushing tags

    Currently we specify pushing the tag before updating any of the
    branches. This creates a potential of creating and pushing a tag
    on an out of sync branch, and only really when attempting to merge
    the release commit that things have gone out of sync.
    
    Changing the order here would minimize the possibility of this error
    
    PR-URL: #31855
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    MylesBorins authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    a468392 View commit details
    Browse the repository at this point in the history
  43. src: elevate v8 namespaces

    PR-URL: #31901
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    HarshithaKP authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    9f68e14 View commit details
    Browse the repository at this point in the history
  44. deps: move zlib maintenance info to guides

    deps/zlib/README.md is not part of the upstream zlib, it is a Node.js
    specific addition describing how to maintain zlib and should be in
    doc/guides/.
    
    PR-URL: #31800
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    sam-github authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    b30a698 View commit details
    Browse the repository at this point in the history
  45. doc: describe how to update zlib

    See:
    - #31201
    
    PR-URL: #31800
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    sam-github authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    4c6343f View commit details
    Browse the repository at this point in the history
  46. deps: update zlib to upstream d7f3ca9

    Updated as described in doc/guides/maintaining-zlib.md.
    
    PR-URL: #31800
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    sam-github authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    c27f0d1 View commit details
    Browse the repository at this point in the history
  47. src: include large pages source unconditionally

    Restrict the usage of the C preprocessor directive enabling large
    pages support to the large pages implementation. This cleans up the
    code in src/node.cc.
    
    PR-URL: #31904
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Gabriel Schulhof authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    776f379 View commit details
    Browse the repository at this point in the history
  48. test: add secp224k1 check in crypto-dh-stateless

    This commit adds a check to test-crypto-dh-statless to avoid an error if
    the curve secp224k1 is not present. This could occur if node was
    configured with shared-openssl.
    
    The use case for this was building on RHEL 8.1 which only has the
    following curves:
    $ openssl ecparam -list_curves
    secp224r1 : NIST/SECG curve over a 224 bit prime field
    secp256k1 : SECG curve over a 256 bit prime field
    secp384r1 : NIST/SECG curve over a 384 bit prime field
    secp521r1 : NIST/SECG curve over a 521 bit prime field
    prime256v1: X9.62/SECG curve over a 256 bit prime field
    
    PR-URL: #31715
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    danbev authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    e08fef1 View commit details
    Browse the repository at this point in the history
  49. tools: add NODE_TEST_NO_INTERNET to the doc builder

    At the moment the doc builder tries to access the internet
    for CHANGELOG information and only falls back to local sources
    after the connection fails or a 5 second timeout. This means
    that the doc building could take at least 7 minutes on a
    machine with hijacked connection to Github for useless network
    attempts. This patch adds a NODE_TEST_NO_INTERNET environment
    variable to directly bypass these attempts so that docs can be
    built in reasonable time on a machine like that.
    
    PR-URL: #31849
    Fixes: #29918
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    joyeecheung authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    f293dcf View commit details
    Browse the repository at this point in the history
  50. doc: updated YAML version representation in readline.md

    All other versions in YAML throughout the docs start with _v_. Fix two
    cases in `readline.md` that did not.
    
    PR-URL: #31924
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    c5acf0a View commit details
    Browse the repository at this point in the history
  51. vm: implement vm.measureMemory() for per-context memory measurement

    This patch implements `vm.measureMemory()` with the new
    `v8::Isolate::MeasureMemory()` API to measure per-context memory
    usage. This should be experimental, since detailed memory
    measurement requires further integration with the V8 API
    that should be available in a future V8 update.
    
    PR-URL: #31824
    Refs: https://github.com/ulan/performance-measure-memory
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    joyeecheung authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    ae3929e View commit details
    Browse the repository at this point in the history
  52. async_hooks: executionAsyncResource matches in hooks

    Ensure that resource returned by executionAsyncResource() in before
    and after hook matches that resource causing this before/after calls.
    
    PR-URL: #31821
    Refs: #30959
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Flarna authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    6af9e7e View commit details
    Browse the repository at this point in the history
  53. test: mark empty udp tests flaky on OS X

    They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X.
    
    Refs: #30030
    Refs: nodejs/build#2189 (comment)
    
    PR-URL: #31936
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    sam-github authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    f89fb27 View commit details
    Browse the repository at this point in the history
  54. meta: move not-an-aardvark to emeritus

    not-an-aardvark confirmed in email that it's probably time for him to
    move to emeritus.
    
    PR-URL: #31928
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    b74c40e View commit details
    Browse the repository at this point in the history
  55. test: fix typo in common/index.js

    All tests using enoughTestCpu checks are always having the checks come
    back false due to a typo in common/index.js. Fix the typo.
    
    PR-URL: #31931
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    918c2b6 View commit details
    Browse the repository at this point in the history
  56. test: add documentation for common.enoughTestCpu

    PR-URL: #31931
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Trott authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    04eda02 View commit details
    Browse the repository at this point in the history
  57. module: disable conditional exports, self resolve warnings

    PR-URL: #31845
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    guybedford authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    b9f3bfe View commit details
    Browse the repository at this point in the history
  58. src: enable StreamPipe for generic StreamBases

    Originally landed in the nodejs/quic repo and used there for file
    sending.
    
    Original review:
    
    ```
      PR-URL: nodejs/quic#150
      Reviewed-By: James M Snell <jasnell@gmail.com>
    ```
    
    PR-URL: #31869
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    addaleax authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    f62967c View commit details
    Browse the repository at this point in the history
  59. doc: clarify http2.connect authority details

    Fixes: #31827
    
    PR-URL: #31828
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Signed-off-by: James M Snell <jasnell@gmail.com>
    jasnell authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    8516602 View commit details
    Browse the repository at this point in the history
  60. doc: update zlib doc

    Just some general improvements to zlib docs and examples
    
    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #31665
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    jasnell authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    e3258fd View commit details
    Browse the repository at this point in the history
  61. repl: eager-evaluate input in parens

    PR-URL: #31943
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    6adbfac View commit details
    Browse the repository at this point in the history
  62. test: increase timeout in vm-timeout-escape-queuemicrotask

    It looks like under high load the loop isn't even started and therefore
    successfully finishes without 'escaping'. After increasing the timeout
    during parallel run of the test failure rate decreased from 15/1000 to
    0/1000.
    
    PR-URL: #31966
    Refs: #25529
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    lundibundi authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    49c959d View commit details
    Browse the repository at this point in the history
  63. test: fix usage of invalid common properties

    PR-URL: #31933
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    lundibundi authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    ab8f060 View commit details
    Browse the repository at this point in the history
  64. test: validate common property usage

    `common` contains multiple 'check'(boolean) properties that will be
    false if mistyped and may lead to errors.
    This makes sure that the used property exists in the `common`.
    
    PR-URL: #31933
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    lundibundi authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    f1e7648 View commit details
    Browse the repository at this point in the history
  65. build: add missing comma in node.gyp

    This commit adds a missing comma for consistency with the
    surrounding lines.
    
    PR-URL: #31959
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    cjihrig authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    ca44071 View commit details
    Browse the repository at this point in the history
  66. src: move InternalCallbackScope to StartExecution

    PR-URL: #31944
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    3497370 View commit details
    Browse the repository at this point in the history
  67. async_hooks: add store arg in AsyncLocalStorage

    This commit introduces store as the first argument in
    AsyncLocalStorage's run methods. The change is motivated by the
    following expectation: most users are going to use a custom object
    as the store and an extra Map created by the previous implementation
    is an overhead for their use case.
    
    Important note. This is a backwards incompatible change.
    It was discussed and agreed an incompatible change is ok
    since the API is still experimental and the modified
    methods were only added within the last week so usage
    will be minimal to none.
    
    PR-URL: #31930
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    puzpuzpuz authored and codebytere committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    f71fc90 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2020

  1. stream: invoke buffered write callbacks on error

    Refs: #30596
    
    Buffered write callbacks were only invoked upon
    error if `autoDestroy` was invoked.
    
    Backport-PR-URL: #31179
    PR-URL: #30596
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    ronag authored and codebytere committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    d0a0071 View commit details
    Browse the repository at this point in the history
  2. src: don't run bootstrapper in CreateEnvironment

    PR-URL: #31910
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    codebytere committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    6a35b0d View commit details
    Browse the repository at this point in the history
  3. module: port source map sort logic from chromium

    Digging in to the delta between V8's source map library, and chromium's
    the most significant difference that jumped out at me was that we were
    failing to sort generated columns. Since negative offsets are not
    restricted in the spec, this can lead to bugs.
    
    fixes: #31286
    
    PR-URL: #31927
    Fixes: #31286
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    bcoe authored and codebytere committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    9e3e676 View commit details
    Browse the repository at this point in the history
  4. test: remove sequential/test-https-keep-alive-large-write.js

    Remove a test that made a flawed assumption that a single
    large buffer write can be interrupted by a timeout event.
    
    PR-URL: #31499
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    rustyconover authored and codebytere committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    cef5502 View commit details
    Browse the repository at this point in the history
  5. test: change test to not be sensitive to buffer send size

    Change the test to not be sensitive to the buffer size causing
    TCP resets to be received by the client causing the test to fail.
    The test now reads the entire expected buffer and then checks for
    the expected event to fire.
    
    PR-URL: #31499
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    rustyconover authored and codebytere committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    b6d33f6 View commit details
    Browse the repository at this point in the history
  6. tls: reduce memory copying and number of BIO buffer allocations

    Avoid copying buffers before passing to SSL_write if there
    are zero length buffers involved.  Only copy the data when
    the buffer has a non zero length.
    
    Send a memory allocation hint to the crypto BIO about how much
    memory will likely be needed to be allocated by the next call
    to SSL_write.  This makes a single allocation rather than the BIO
    allocating a buffer for each 16k TLS segment written.  This
    solves a problem with large buffers written over TLS triggering
    V8's GC.
    
    PR-URL: #31499
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    rustyconover authored and codebytere committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    2c0b249 View commit details
    Browse the repository at this point in the history
  7. crypto: turn impossible DH errors into assertions

    PR-URL: #31934
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and codebytere committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    4d05508 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2020

  1. stream: support passing generator functions into pipeline()

    Backport-PR-URL: #31975
    PR-URL: #31223
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    ronag authored and codebytere committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    8ad64b8 View commit details
    Browse the repository at this point in the history
  2. stream: fix broken pipeline error propagation

    If the destination was an async function any
    error thrown from that function would be swallowed.
    
    Backport-PR-URL: #31975
    PR-URL: #31835
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    ronag authored and codebytere committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    313ecaa View commit details
    Browse the repository at this point in the history
  3. stream: ensure pipeline always destroys streams

    There was an edge case where an incorrect assumption was made
    in regardos whether eos/finished means that the stream is
    actually destroyed or not.
    
    Backport-PR-URL: #31975
    PR-URL: #31940
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ronag authored and codebytere committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    8a2b62e View commit details
    Browse the repository at this point in the history
  4. deps: V8: backport f7771e5b0cc4

    Original commit message:
    
        [runtime] Recompute enumeration indices of dictionaries upon bitfield overflow
    
        Otherwise we'll get weird semantics when enumerating objects after many
        deletes/reinserts.
    
        Bug: chromium:1033771
        Change-Id: If0a459169c3794a30d9632d09e80da3cfcd4302c
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1993966
        Commit-Queue: Toon Verwaest <verwaest@chromium.org>
        Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
        Reviewed-by: Victor Gomes <victorgomes@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#65690}
    
    Refs: v8/v8@f7771e5
    
    PR-URL: #31957
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    mmarchini authored and codebytere committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    e6125cd View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. meta: move Glen Keane to Collaborator Emeritus

    In email, Glen confirmed that he is happy to move to Emeritus. He also
    informed me that his handle is no longer thekemkid and is now glentiki.
    At his request, I've updated the handle in the README in addition to
    moving him to Emeritus.
    
    PR-URL: #31993
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and codebytere committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    91ce69a View commit details
    Browse the repository at this point in the history
  2. meta: move maclover7 to Emeritus

    In email, maclover7 confirmed that are fine to move to emeritus status.
    
    PR-URL: #31994
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and codebytere committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    ded3890 View commit details
    Browse the repository at this point in the history
  3. meta: move jbergstroem to emeritus

    jbergstroem confirmed in email that they should go to collaborator
    emeritus. They still have their toe in the Build WG and will stay on
    there. Who knows, maybe they'll be back as a Collaborator before we know
    it.
    
    PR-URL: #31996
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and codebytere committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    c801045 View commit details
    Browse the repository at this point in the history
  4. meta: move aqrln to emeritus

    aqrln confirmed in email that it makes sense to move them to emeritus at
    this point.
    
    PR-URL: #31997
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Trott authored and codebytere committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    3bd8fea View commit details
    Browse the repository at this point in the history
  5. test: fix flaky test-gc-net-timeout

    If the timeout is called in the time between 'end' and 'close'
    that would cause a EPIPE error. Essentially making the test flaky.
    
    PR-URL: #31918
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    ronag authored and codebytere committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    3849474 View commit details
    Browse the repository at this point in the history
  6. build: only lint markdown files that have changed (POSIX-only)

    Update Makefile so that only markdown files that have changed will be
    linted. Currently, if one file in doc/api has changed, all files in
    doc/api are linted.
    
    On Windows, the lint-md task currently lints all files regardless of
    whether any files has changed, and that behavior is unchanged here.
    
    A further improvement is that when tools/lint-md.js is rebuilt, the
    timestamp file is removed so that all files are linted again. This is
    because rebuilding lint-md.js can introduce new rules or modify existing
    rules, so re-linting everything helps make sure that accidental breakage
    doesn't slip by unnoticed.
    
    PR-URL: #31923
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Trott authored and codebytere committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    9a41ced View commit details
    Browse the repository at this point in the history
  7. doc: add link to sem-ver info

    PR-URL: #31985
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    rosaxxny authored and codebytere committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    166579f View commit details
    Browse the repository at this point in the history
  8. test: fix flaky test-dns-any.js

    Remove google.com from domains tested with ANY queries.
    
    Fixes: #31721
    
    PR-URL: #32017
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and codebytere committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    49864d1 View commit details
    Browse the repository at this point in the history
  9. doc: revise --zero-fill-buffers text in buffer.md

    There was an unclear sentence fragment that needed fixing, so I edited
    the entire paragraph for clarity. I also removed irrelevant information
    about behavior before Node.js 8.0.0. That version of Node.js is no
    longer supported and these docs will never apply to 8.0.0. (At the time
    of this writing, 10.x is the oldest supported line, and so changes to
    the docs will never be backported farther than the 10.x docs.)
    
    PR-URL: #32019
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Trott authored and codebytere committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    cd30dbb View commit details
    Browse the repository at this point in the history
  10. test: improve disable AsyncLocalStorage test

    PR-URL: #31998
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    puzpuzpuz authored and codebytere committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    9325634 View commit details
    Browse the repository at this point in the history
  11. deps: openssl: cherry-pick 4dcb150ea30f

    OpenSSL 1.1.1d does not ship with getrandom syscall being
    predefined on all architectures. So when NodeJS is run with glibc
    prior to 2.25, where getentropy is unavailable, and the getrandom
    syscall is unknown, it will fail. PPC64LE or s390 are affected
    by lack of this definition.
    
    Original commit message.
    
        commit 4dcb150ea30f9bbfa7946e6b39c30a86aca5ed02
        Author: Kurt Roeckx <kurt@roeckx.be>
        Date:   Sat Sep 28 14:59:32 2019 +0200
    
          Add defines for __NR_getrandom for all Linux architectures
    
          Fixes: openssl/openssl#10015
    
          Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
          GH: openssl/openssl#10044
    
    Fixes: #31671
    PR-URL: #32002
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    AdamMajer authored and codebytere committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    fbaab7d View commit details
    Browse the repository at this point in the history
  12. test: move test-inspector-module to parallel

    test-inspector-module is very fast and seems to be runnable at the same
    time as other tests. Move from sequential directory to parallel.
    
    PR-URL: #32025
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and codebytere committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    1bca7b6 View commit details
    Browse the repository at this point in the history
  13. 2020-03-04 Version 13.10.0 (Current)

    Notable changes:
    
    * async_hooks
      * introduce async-context API (vdeturckheim) #26540
    * stream
      * support passing generator functions into pipeline() (Robert Nagy) #31223
    * tls
      * expose SSL\_export\_keying\_material (simon) #31814
    * vm
      * implement vm.measureMemory() for per-context memory measurement (Joyee Cheung) #31824
    
    PR-URL: #32027
    codebytere committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    f6ffdc2 View commit details
    Browse the repository at this point in the history