Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: eos make const state const #32031

Closed
wants to merge 3 commits into from
Closed

stream: eos make const state const #32031

wants to merge 3 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Mar 1, 2020

writable & readable is based on type and is not actual state, treat them as such. Also fixes an invalid test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag requested a review from mafintosh March 1, 2020 18:21
@ronag ronag requested review from mcollina and mafintosh and removed request for mafintosh March 1, 2020 18:21
mcollina
mcollina approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29471/

@ronag ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem. wip Issues and PRs that are still a work in progress. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 1, 2020
@ronag
Copy link
Member Author

ronag commented Mar 1, 2020

CI failed, needs investigating

@ronag ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed wip Issues and PRs that are still a work in progress. labels Mar 1, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29472/

@ronag ronag requested a review from lpinca March 1, 2020 19:51
lpinca
lpinca approved these changes Mar 1, 2020
View reviewed changes
lib/internal/streams/end-of-stream.js Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29513/

@ronag
stream: eos make const state const
9d1ee32 
writable & readable is based on type and is not actual
state, treat them as such.
@ronag
fixup: test
efd93fb
@ronag
fixup: nit
f050b72
@ronag
Copy link
Member Author

ronag commented Mar 3, 2020

rebased to fix conflicts

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29515/

ronag added a commit that referenced this pull request Mar 3, 2020
@ronag
stream: eos make const state const
8429295 
writable & readable is based on type and is not actual
state, treat them as such.

PR-URL: #32031
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ronag
Copy link
Member Author

ronag commented Mar 3, 2020

Landed in 8429295

@ronag ronag closed this Mar 3, 2020
@MylesBorins
Copy link
Member

This doesn't land cleanly on v13.x. If it is applicable to that release line could you please open a backporrt

@MylesBorins MylesBorins mentioned this pull request Mar 9, 2020
Closed
7 tasks
@ronag ronag mentioned this pull request Mar 10, 2020
Closed
4 tasks
ronag added a commit to nxtedition/node that referenced this pull request Mar 10, 2020
@ronag
stream: eos make const state const
18e5e53 
writable & readable is based on type and is not actual
state, treat them as such.

PR-URL: nodejs#32031
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Backport-PR-URL: nodejs#32178
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
@ronag @MylesBorins
stream: eos make const state const
f263659 
writable & readable is based on type and is not actual
state, treat them as such.

Backport-PR-URL: #32178
PR-URL: #32031
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@lpinca lpinca lpinca approved these changes

@mafintosh mafintosh Awaiting requested review from mafintosh

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ronag @nodejs-github-bot @MylesBorins @mcollina @lpinca @addaleax @targos