Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] deps: update V8 to 8.0 #32095

Closed
wants to merge 22 commits into from
Closed

[WIP] deps: update V8 to 8.0 #32095

wants to merge 22 commits into from

Commits on Mar 4, 2020

  1. Configuration menu
    Copy the full SHA
    7d7d748 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d77064c View commit details
    Browse the repository at this point in the history
  3. src: update NODE_MODULE_VERSION to 83

    Major V8 updates are usually API/ABI incompatible with previous
    versions. This commit adapts NODE_MODULE_VERSION for V8 8.0.
    
    Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
    mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    03b51c2 View commit details
    Browse the repository at this point in the history
  4. deps: V8: un-cherry-pick bd019bd

    Original commit message:
    
        [testrunner] delete ancient junit compatible format support
    
        Testrunner has ancient support for JUnit compatible XML output.
    
        This CL removes this old feature.
    
        R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
        CC=​machenbach@chromium.org
    
        Bug: v8:8728
        Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
        Reviewed-on: https://chromium-review.googlesource.com/c/1430065
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
        Commit-Queue: Tamer Tas <tmrts@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#59045}
    
    Refs: v8/v8@bd019bd
    
    PR-URL: nodejs#26685
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    refack authored and mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    997b2b5 View commit details
    Browse the repository at this point in the history
  5. deps: V8: silence irrelevant warnings

    PR-URL: nodejs#26685
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    targos authored and mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    60f3e5e View commit details
    Browse the repository at this point in the history
  6. deps: patch V8 to run on older XCode versions

    Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional
    property, which is a fairly new C++ feature, since that requires a newer
    XCode version than the minimum requirement in BUILDING.md and thus
    breaks CI.
    
    PR-URL: nodejs#29694
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    ryzokuken authored and mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    8ceed05 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    be1fd19 View commit details
    Browse the repository at this point in the history
  8. tools: update V8 gypfiles for V8 8.0

    Co-authored-by: Ujjwal Sharma <usharma1998@gmail.com>
    2 people authored and mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    7690bcb View commit details
    Browse the repository at this point in the history
  9. src: stop overriding deprecated V8 methods

    These methods will be removed in V8 8.1, hence we need to stop
    overriding them.
    backes authored and mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    f24c774 View commit details
    Browse the repository at this point in the history
  10. Revert "assert: fix line number calculation after V8 upgrade"

    This reverts commit 5981fb7.
    targos authored and mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    3ab0e61 View commit details
    Browse the repository at this point in the history
  11. test: update test-postmortem-metadata.js

    The following metadata has changed in V8:
    
    - v8dbg_class_ConsString__first_offset__int
      - Use v8dbg_class_ConsString__first__String instead.
      - Refs: v8/v8@b38dfaf
    
    - v8dbg_class_ConsString__second_offset__int
      - Use v8dbg_class_ConsString__second__String instead.
      - Refs: v8/v8@b38dfaf
    
    - v8dbg_class_Map__constructor_or_backpointer__Object
      - This constant has not changed, but the postmortem metadata generation
        script required an update.
    
    - v8dbg_class_SlicedString__offset_offset__int
      - Use v8dbg_class_SlicedString__offset__SMI instead.
      - Refs: v8/v8@b38dfaf
    
    - v8dbg_class_ThinString__actual_offset__int
      - Use v8dbg_class_ThinString__actual__String instead.
      - Refs: v8/v8@b38dfaf
    cjihrig authored and mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    60e7d9f View commit details
    Browse the repository at this point in the history
  12. src: update v8abbr.h for V8 update

    This commit updates v8abbr.h to use the updated metadata.
    cjihrig authored and mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    35ad809 View commit details
    Browse the repository at this point in the history
  13. deps: bump minimum icu version to 65

    Bump minimum version of ICU needed to build node to 65.
    
    Refs: v8/v8@74bf96e
    targos authored and mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    3ebef4b View commit details
    Browse the repository at this point in the history
  14. src: remove use of deprecated Symbol::Name()

    This commit replaces Symbol::Name() with
    Symbol::Description().
    
    Fixes: nodejs#30916
    cjihrig authored and mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    93681bc View commit details
    Browse the repository at this point in the history
  15. Update tests for larger Buffers

    V8 is about to increase the max TypedArray length to 2**32-1, which
    Node inherits as Buffer.kMaxLength. Some tests relied on values greater
    than the previous max length (2**31-1) to throw errors; this updates
    those tests for the new max length.
    jakobkummerow authored and mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    e9b7f47 View commit details
    Browse the repository at this point in the history
  16. Remove checks for deserializing wasm

    Serialization support of WasmModuleObjects will be removed in
    https://crrev.com/c/2013110, thus we need to stop testing for that.
    backes authored and mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    6ae7004 View commit details
    Browse the repository at this point in the history
  17. Avoid calling deprecated method

    The {SetExpectInlineWasm} method is deprecated and non-functional since
    V8 v8.1.
    Thus node should stop calling it, so that it can be fully removed in a
    future v8 version.
    backes authored and mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    432a7b5 View commit details
    Browse the repository at this point in the history
  18. Remove deprecated wasm type check

    This removes uses of the "IsWebAssemblyCompiledModule" method, which is
    deprecated in V8 v8.1 and will be removed in v8.2.
    We could replace it by "IsWasmModuleObject", but since it's unused in
    node anyway, I just remove the definition.
    backes authored and mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    57613f5 View commit details
    Browse the repository at this point in the history
  19. Remove test

    backes authored and mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    2cbbee2 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    819820d View commit details
    Browse the repository at this point in the history
  21. tools: update v8.gyp

    richardlau authored and mmarchini committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    fdc1554 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2020

  1. deps: V8: cherry-pick e8e324aa9d5f

    Original commit message:
    
        Fix MSVC component build
    
        Add the necessary V8_EXPORT_PRIVATE attributes and a few other minor
        changes to make building DLLs with MSVC happy. (Note: Debug builds still
        seem to be failing in Torque, but this fixes Release builds).
    
        Bug: v8:8791
        Change-Id: Ia4d5372fd1cb961e6268a2b5c089bcd17822f1e5
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1996157
        Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
        Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
        Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
        Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#65822}
    
    Refs: v8/v8@e8e324a
    mmarchini committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    1d54faf View commit details
    Browse the repository at this point in the history