Commits on Mar 16, 2020

1. deps: update V8 to 8.1.307.20

   

   mmarchini committed Mar 16, 2020
   Copy the full SHA

   ca24f95 View commit details

   Browse the repository at this point in the history

2. build: reset embedder string to "-node.0"

   

   mmarchini committed Mar 16, 2020
   Copy the full SHA

   ae159b5 View commit details

   Browse the repository at this point in the history

3. src: update NODE_MODULE_VERSION to 83 …

   Major V8 updates are usually API/ABI incompatible with previous
   versions. This commit adapts NODE_MODULE_VERSION for V8 8.1.
   
   Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

   

   mmarchini committed Mar 16, 2020
   Copy the full SHA

   f03be8e View commit details

   Browse the repository at this point in the history

4. tools: update V8 gypfiles for 8.1 …

   Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl>
   Co-authored-by: Michaël Zasso <targos@protonmail.com>
   Co-authored-by: Richard Lau <riclau@uk.ibm.com>
   Co-authored-by: Ujjwal Sharma <ryzokuken@igalia.com>

   

   

   5 people committed Mar 16, 2020
   Copy the full SHA

   23df7d9 View commit details

   Browse the repository at this point in the history

5. deps: update V8 dtrace & postmortem metadata

   

   cjihrig authored and mmarchini committed Mar 16, 2020
   Copy the full SHA

   5703918 View commit details

   Browse the repository at this point in the history

6. deps: V8: un-cherry-pick bd019bd …

   Original commit message:
   
       [testrunner] delete ancient junit compatible format support
   
       Testrunner has ancient support for JUnit compatible XML output.
   
       This CL removes this old feature.
   
       R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
       CC=​machenbach@chromium.org
   
       Bug: v8:8728
       Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
       Reviewed-on: https://chromium-review.googlesource.com/c/1430065
       Reviewed-by: Jakob Gruber <jgruber@chromium.org>
       Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
       Commit-Queue: Tamer Tas <tmrts@chromium.org>
       Cr-Commit-Position: refs/heads/master@{#59045}
   
   Refs: v8/v8@bd019bd

   

   refack authored and mmarchini committed Mar 16, 2020
   Copy the full SHA

   840e401 View commit details

   Browse the repository at this point in the history

7. deps: patch V8 to run on older XCode versions …

   Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional
   property, which is a fairly new C++ feature, since that requires a newer
   XCode version than the minimum requirement in BUILDING.md and thus
   breaks CI.

   

   ryzokuken authored and mmarchini committed Mar 16, 2020
   Copy the full SHA

   aeec277 View commit details

   Browse the repository at this point in the history

8. deps: V8: patch register-arm64.h …

   Fixes a compilation issue on some platforms

   

   refack authored and mmarchini committed Mar 16, 2020
   Copy the full SHA

   b988094 View commit details

   Browse the repository at this point in the history

9. deps: V8: forward declaration of Rtl*FunctionTable …

   This should be semver-patch since actual invocation is version
   conditional.

   

   refack authored and mmarchini committed Mar 16, 2020
   Copy the full SHA

   1d42476 View commit details

   Browse the repository at this point in the history

10. deps: make v8.h compatible with VS2015 …

    There is a bug in the most recent version of VS2015 that affects v8.h
    and therefore prevents compilation of addons.
    
    Refs: https://stackoverflow.com/q/38378693

    

    joaocgreis authored and mmarchini committed Mar 16, 2020
    Copy the full SHA

    c2cd5c9 View commit details

    Browse the repository at this point in the history

11. Revert "assert: fix line number calculation after V8 upgrade" …

    This reverts commit 5981fb7.

    

    targos authored and mmarchini committed Mar 16, 2020
    Copy the full SHA

    355ec99 View commit details

    Browse the repository at this point in the history

12. deps: bump minimum icu version to 65 …

    Bump minimum version of ICU needed to build node to 65.
    
    Refs: v8/v8@74bf96e

    

    targos authored and mmarchini committed Mar 16, 2020
    Copy the full SHA

    9cc96f0 View commit details

    Browse the repository at this point in the history

13. deps: V8: cherry-pick 1e36e21acc40 …

    Original commit message:
    
        Remove unnecessary export, which happens to break MSVC DLL builds.
    
        Change-Id: I47c9211274cefd26bde6bd93aa7503e022df4357
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2042874
        Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
        Commit-Queue: Bill Ticehurst <billti@microsoft.com>
        Cr-Commit-Position: refs/heads/master@{#66179}
    
    Refs: v8/v8@1e36e21

    

    mmarchini committed Mar 16, 2020
    Copy the full SHA

    3c9902f View commit details

    Browse the repository at this point in the history

14. deps: V8: cherry-pick 931bdbd76f5b …

    Original commit message:
    
        [torque] fix build on VS2017
    
        Node.js build fails on VS2017 without these headers, see the downstream
        issue (nodejs/node-v8#128).
    
        Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl>
        Co-authored-by: gengjiawen <technicalcute@gmail.com>
        Change-Id: I771eab435dce5cf548581f3acd78681180c77692
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2093951
        Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
        Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#66661}
    
    Refs: v8/v8@931bdbd

    

    mmarchini committed Mar 16, 2020
    Copy the full SHA

    04e0e67 View commit details

    Browse the repository at this point in the history

15. deps: V8: silence irrelevant warnings …

    PR-URL: nodejs#26685
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>

    

    targos authored and mmarchini committed Mar 16, 2020
    Copy the full SHA

    2b3d7d8 View commit details

    Browse the repository at this point in the history

16. deps: patch V8 to run on Xcode 8 …

    Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type
    passed to template call of `OwnedVector::Of`. Xcode 8 can't convert
    'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when
    returning from a function (which is likely a bug on Xcode, considering
    this worked on the prior version of Xcode as well as newer versions).
    This workaround shouldn't affect the application, since the const
    qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_.
    
    There's also a V8 test passing a const-qualified type to ::Of, but since
    we don't test V8 on Xcode 8, it should be fine to leave it as is.
    
    Signed-off-by: Matheus Marchini <mmarchini@netflix.com>

    

    mmarchini committed Mar 16, 2020
    Copy the full SHA

    17215ef View commit details

    Browse the repository at this point in the history

17. src: stop overriding deprecated V8 methods …

    These methods will be removed in V8 8.1, hence we need to stop
    overriding them.

    

    backes authored and mmarchini committed Mar 16, 2020
    Copy the full SHA

    868f6a6 View commit details

    Browse the repository at this point in the history

18. src: remove use of deprecated Symbol::Name() …

    This commit replaces Symbol::Name() with
    Symbol::Description().
    
    Fixes: nodejs#30916

    

    cjihrig authored and mmarchini committed Mar 16, 2020
    Copy the full SHA

    3943f56 View commit details

    Browse the repository at this point in the history

19. src: avoid calling deprecated method …

    The {SetExpectInlineWasm} method is deprecated and non-functional since
    V8 v8.1.
    Thus node should stop calling it, so that it can be fully removed in a
    future v8 version.

    

    backes authored and mmarchini committed Mar 16, 2020
    Copy the full SHA

    cf436e1 View commit details

    Browse the repository at this point in the history

20. src: remove deprecated wasm type check …

    This removes uses of the "IsWebAssemblyCompiledModule" method, which is
    deprecated in V8 v8.1 and will be removed in v8.2.
    We could replace it by "IsWasmModuleObject", but since it's unused in
    node anyway, I just remove the definition.

    

    backes authored and mmarchini committed Mar 16, 2020
    Copy the full SHA

    41150e1 View commit details

    Browse the repository at this point in the history

21. test: remove checks for deserializing wasm …

    V8 is removing support for serializing wasm modules via the value
    serializer. Once this is complete (https://crrev.com/c/2013110), we can
    re-add this test.

    

    mmarchini committed Mar 16, 2020
    Copy the full SHA

    9dff644 View commit details

    Browse the repository at this point in the history

22. test: remove test

    

    backes authored and mmarchini committed Mar 16, 2020
    Copy the full SHA

    ff41527 View commit details

    Browse the repository at this point in the history

23. src: migrate measureMemory to new v8 api

    

    gengjiawen authored and mmarchini committed Mar 16, 2020
    Copy the full SHA

    11949c1 View commit details

    Browse the repository at this point in the history

24. build: temporarily skip ASAN build …

    GitHub Actions doesn't have enough memory to complete an ASAN+Debug with
    V8 8.1. Don't take ASAN into account on CI results until we find a
    workaround, or until we upgrade to V8 8.2.

    

    mmarchini committed Mar 16, 2020
    Copy the full SHA

    9dac823 View commit details

    Browse the repository at this point in the history