Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x backport] async_hooks: add executionAsyncResource #32131

Closed
wants to merge 4 commits into from
Closed

[v12.x backport] async_hooks: add executionAsyncResource #32131

wants to merge 4 commits into from

Commits on Apr 14, 2020

  1. async_hooks: add executionAsyncResource 

    Remove the need for the destroy hook in the basic APM case.

Co-authored-by: Stephen Belanger <admin@stephenbelanger.com>
PR-URL: nodejs#30959
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @mcollina @Qard @puzpuzpuz
    2 people authored and puzpuzpuz committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    cd36fc7 View commit details
    Browse the repository at this point in the history

  2. async_hooks: executionAsyncResource matches in hooks 

    Ensure that resource returned by executionAsyncResource() in before
and after hook matches that resource causing this before/after calls.

PR-URL: nodejs#31821
Refs: nodejs#30959
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    @Flarna @puzpuzpuz
    Flarna authored and puzpuzpuz committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    0a7da1c View commit details
    Browse the repository at this point in the history

  3. src: move InternalCallbackScope to StartExecution 

    PR-URL: nodejs#31944
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @codebytere @puzpuzpuz
    codebytere authored and puzpuzpuz committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    0e12a43 View commit details
    Browse the repository at this point in the history

  4. src: pass resource object along with InternalMakeCallback 

    This was an oversight in 9fdb6e6.
Fixing this is necessary to make `executionAsyncResource()` work
as expected.

Refs: nodejs#30959
Fixes: nodejs#32060

PR-URL: nodejs#32063
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @addaleax @puzpuzpuz
    addaleax authored and puzpuzpuz committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    fc50e29 View commit details
    Browse the repository at this point in the history