Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove personal pronouns in reference docs prose #32142

Closed
wants to merge 0 commits into from
Closed

doc: remove personal pronouns in reference docs prose #32142

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 8, 2020

Per style guide, avoid personal pronouns in reference docs, hopefully without introducing a ton of passive voice.

Lint rule is possible, but I personally want to take some time to make sure this isn't a guideline we want to keep. For now, though, abide by it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 8, 2020
@Trott Trott changed the title doc: remove personal pronouns doc: remove personal pronouns in reference docs prose Mar 8, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2020
@Trott
Copy link
Member Author

Trott commented Mar 10, 2020

Landed in 66e32ff...73f2dbc

Trott added a commit to Trott/io.js that referenced this pull request Mar 10, 2020
@Trott
doc: remove personal pronoun usage in addons.md
36ce039 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Mar 10, 2020
@Trott
doc: remove personal pronoun usage in errors.md
c37c21b 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Mar 10, 2020
@Trott
doc: remove personal pronoun usage in fs.md
fb36266 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Mar 10, 2020
@Trott
doc: remove personal pronoun usage in policy.md
73f2dbc 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott Trott closed this Mar 10, 2020
@Trott Trott deleted the de-you branch March 10, 2020 02:48
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
@Trott @MylesBorins
doc: remove personal pronoun usage in addons.md
2d39369 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: #32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
@Trott @MylesBorins
doc: remove personal pronoun usage in errors.md
fa99fb2 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: #32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
@Trott @MylesBorins
doc: remove personal pronoun usage in fs.md
618b389 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: #32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
@Trott @MylesBorins
doc: remove personal pronoun usage in policy.md
7de4dfb 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: #32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
Merged
@targos targos added backport-blocked-v12.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x labels Apr 20, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@Trott @targos
doc: remove personal pronoun usage in addons.md
ba094df 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@Trott @targos
doc: remove personal pronoun usage in errors.md
d9991c2 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@Trott @targos
doc: remove personal pronoun usage in fs.md
9fbab23 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@Trott @targos
doc: remove personal pronoun usage in policy.md
2cba792 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@Trott @targos
doc: remove personal pronoun usage in addons.md
c98ba95 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: #32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@Trott @targos
doc: remove personal pronoun usage in errors.md
9a7f892 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: #32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@Trott @targos
doc: remove personal pronoun usage in fs.md
97689e0 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: #32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@Trott @targos
doc: remove personal pronoun usage in policy.md
c0cf234 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: #32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Trott @tniessen @BridgeAR @trivikr @targos @nodejs-github-bot