Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12.x backport] doc: remove em dashes #32146

Closed

Commits on Mar 8, 2020

  1. test: mark empty udp tests flaky on OS X

    They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X.
    
    Refs: nodejs#30030
    Refs: nodejs/build#2189 (comment)
    
    PR-URL: nodejs#31936
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    sam-github authored and puzpuzpuz committed Mar 8, 2020
    Copy the full SHA
    0b5fda0 View commit details
    Browse the repository at this point in the history
  2. doc: remove em dashes

    Our documentation uses em dashes inconsistently. They are treated
    inconsistently typographically too. (For example, they are sometimes
    surrounded by spaces and sometimes not.) They are also often confused
    with ordinary hyphens such as in the CHANGELOG, where they are
    inadvertently mixed together in a single list. The difference is
    not obvious in the raw markdown but is very noticeable when rendered,
    appearing to be a typographical error (which it in fact is).
    
    The em dash is never needed. There are always alternatives. Remove em
    dashes entirely.
    
    PR-URL: nodejs#32080
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and puzpuzpuz committed Mar 8, 2020
    Copy the full SHA
    f5a4000 View commit details
    Browse the repository at this point in the history