Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: handle on-fatalerror better #32207

Closed
wants to merge 4 commits into from
Closed

report: handle on-fatalerror better #32207

wants to merge 4 commits into from

Commits on Mar 24, 2020

  1. report: handle on-fatalerror better 

    --report-on-fatalerror was not honored properly, as there was no
way to check the value which was stored in the Environment pointer
which can be inaccessible under certain fatal error situations.

Move the flag out of Environment pointer so that this is doable.

Co-authored-by: Shobhit Chittora schittora@paypal.com

Fixes: nodejs#31576
Refs: nodejs#29881
    @HarshithaKP
    HarshithaKP committed Mar 24, 2020
    Copy the full SHA
    175c2e7 View commit details
    Browse the repository at this point in the history

  2. fixup: address review comment

    @HarshithaKP
    HarshithaKP committed Mar 24, 2020
    Copy the full SHA
    7915e7e View commit details
    Browse the repository at this point in the history

  3. fixup: fix linter error

    @HarshithaKP
    HarshithaKP committed Mar 24, 2020
    Copy the full SHA
    3bf8c60 View commit details
    Browse the repository at this point in the history

  4. fixup: fix linter error

    @HarshithaKP
    HarshithaKP committed Mar 24, 2020
    Copy the full SHA
    7dbc5de View commit details
    Browse the repository at this point in the history