Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: move diagnostic reports to stable #32242

Merged
merged 6 commits into from Mar 15, 2020
Merged

report: move diagnostic reports to stable #32242

merged 6 commits into from Mar 15, 2020

Commits on Mar 15, 2020

  1. src: unconditionally include report feature 

    This commit removes all #ifdef NODE_REPORT checks in the src
directory.

PR-URL: nodejs#32242
Fixes: nodejs#26293
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @cjihrig
    cjihrig committed Mar 15, 2020
    Copy the full SHA
    a6bd2c2 View commit details
    Browse the repository at this point in the history

  2. build: remove node_report option in node.gyp 

    PR-URL: nodejs#32242
Fixes: nodejs#26293
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @cjihrig
    cjihrig committed Mar 15, 2020
    Copy the full SHA
    f1d3d92 View commit details
    Browse the repository at this point in the history

  3. build: make --without-report a no-op 

    This commit makes the configure --without-report flag a no-op.
This commit also updates a test that depends on the report CLI
flags being conditionally present.

PR-URL: nodejs#32242
Fixes: nodejs#26293
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @cjihrig
    cjihrig committed Mar 15, 2020
    Copy the full SHA
    765c375 View commit details
    Browse the repository at this point in the history

  4. test: remove common.skipIfReportDisabled() 

    The report feature won't ever be disabled moving forward, so
checking for its existence in the tests is no longer needed.

PR-URL: nodejs#32242
Fixes: nodejs#26293
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @cjihrig
    cjihrig committed Mar 15, 2020
    Copy the full SHA
    4c64e7c View commit details
    Browse the repository at this point in the history

  5. doc,lib,src,test: make --experimental-report a nop 

    This commit makes the --experimental-report CLI flag a no-op.

PR-URL: nodejs#32242
Fixes: nodejs#26293
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @cjihrig
    cjihrig committed Mar 15, 2020
    Copy the full SHA
    9d1a3b6 View commit details
    Browse the repository at this point in the history

  6. doc: update stability of report features 

    This commit updates the stability documentation for the report
feature. All diagnostic report APIs are now listed as stable,
with the exception of report-on-fatalerror, which still has a
few bugs to work out.

PR-URL: nodejs#32242
Fixes: nodejs#26293
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @cjihrig
    cjihrig committed Mar 15, 2020
    Copy the full SHA
    a022d38 View commit details
    Browse the repository at this point in the history