Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12.x] doc: remove reverse-i-search link #32282

Closed
wants to merge 224 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
224 commits
Select commit Hold shift + click to select a range
ec3dea1
src: add build Github Action
gengjiawen Jan 2, 2020
6dc3c5e
doc: fix stream async iterator sample
ronag Jan 7, 2020
7839676
doc: rename iterator to iterable in examples
ronag Jan 7, 2020
b91a48a
doc: update description of `External`
addaleax Jan 8, 2020
bd63c43
lib: add Uint16Array primordials
Sebastien-Ahkrin Jan 6, 2020
096388d
doc: add GeoffreyBooth to collaborators
GeoffreyBooth Jan 10, 2020
1bb6f1b
doc: fix a code example in zlib.md
dragonman225 Jan 8, 2020
689cdc7
src: include uv.h in node_binding header
codebytere Jan 8, 2020
07c3b6d
doc: update README to make Node.js description clearer
carterbancroft Jan 9, 2020
40b5e0e
test: allow disabling crypto tests
codebytere Jan 9, 2020
5961626
fs: add missing HandleScope to FileHandle.close
addaleax Jan 9, 2020
b01b75c
doc: improve doc v8.getHeapSpaceStatistics() 'GetHeapSpaceStatistics'
dev-script Jan 8, 2020
b1742e6
http2: skip creating native ShutdownWrap
addaleax Jan 9, 2020
700e4b5
tools: add clang-tidy rule in src
gengjiawen Jan 8, 2020
2f370f5
build: test Python 3 using GitHub Actions-based CI
cclauss Sep 6, 2019
a6524a3
tools: ensure consistent perms of signed release files
rvagg Aug 28, 2019
0b3bee5
async_hooks: remove internal only error checking
apapirovski Dec 14, 2019
091b40b
tools: update JSON header parsing for backticks
Trott Jan 10, 2020
5e613ff
test: stricten readline keypress failure test condition
BridgeAR Jan 10, 2020
2601e02
deps: upgrade npm to 6.13.6
ruyadorno Jan 10, 2020
476e919
stream: simplify push
ronag Jan 1, 2020
c72fff6
doc: document readline key bindings
HarshithaKP Jan 7, 2020
0184bcd
build: silence c-ares Windows compiler warnings
richardlau Jan 11, 2020
5be9958
build: silence OpenSSL Windows compiler warnings
richardlau Jan 11, 2020
5af51ed
doc: fix example of parsing request.url
NMVikings Jan 10, 2020
d1814b5
lib: replace BigInt64Array global by the primordials
Sebastien-Ahkrin Jan 5, 2020
c2b0929
doc: add an example for util.types.isExternal
HarshithaKP Jan 3, 2020
efa15f3
build: add GitHub actions to run linters
richardlau Jan 12, 2020
621aa1d
build: fix step name in GitHub Actions workflow
richardlau Jan 12, 2020
8818694
errors: remove dead code in ERR_INVALID_ARG_TYPE
Flarna Jan 11, 2020
0fb6538
doc: fix a code example in crypto.md
himself65 Jan 11, 2020
ad081c5
n-api: return napi_invalid_arg on napi_create_bigint_words
legendecas Dec 1, 2019
3af49f1
doc: standardize on "host name" in async_hooks.md
Trott Jan 12, 2020
2763b97
doc: standardize on "host name" in dgram.md
Trott Jan 12, 2020
1ffeb53
doc: standardize on "host name" in errors.md
Trott Jan 12, 2020
08e7c5a
doc: standardize on "host name" in fs.md
Trott Jan 12, 2020
641bf92
doc: standardize on "host name" in http2.md
Trott Jan 12, 2020
de7a76e
doc: standardize on "host name" in https.md
Trott Jan 12, 2020
a546544
doc: standardize on "host name" in net.md
Trott Jan 12, 2020
8df6246
doc: standardize on "host name" in os.md
Trott Jan 12, 2020
788ea98
doc: standardize on "host name" in tls.md
Trott Jan 12, 2020
c6e2fd8
doc: standardize on "host name" in url.md
Trott Jan 12, 2020
e0c9a78
doc: standardize on "host name" in deprecations.md
Trott Jan 12, 2020
2863bef
build: fix macos runner type in GitHub Action
himself65 Jan 12, 2020
50403c5
deps: upgrade to libuv 1.34.1
cjihrig Jan 12, 2020
23761b3
build: add vs2019 to vcbuild.bat help
richardlau Jan 13, 2020
e883136
build: remove enable_vtune from vcbuild.bat
richardlau Jan 13, 2020
7b0687d
src: use uv_guess_handle() to detect TTYs
cjihrig Jan 12, 2020
23a5339
src: fix performance regression in node_file.cc
bnoordhuis Jan 13, 2020
f01351f
tools: update remark-preset-lint-node to 1.12.0
Trott Jan 14, 2020
9a6ae09
tools: remove obsolete dependencies
Trott Jan 14, 2020
c7c0dfe
benchmark: add default type in getstringwidth.js
Trott Jan 16, 2020
1107309
src: ignore GCC -Wcast-function-type for v8.h
danbev Jan 23, 2020
ceaab49
src: fix ignore GCC -Wcast-function-type for older compilers
lundibundi Jan 26, 2020
37e386f
build: do not use setup-node in build workflows
richardlau Jan 14, 2020
c11213e
doc: document missing properties in child_process
HarshithaKP Jan 13, 2020
2154a81
doc: explain _writev() API
HarshithaKP Jan 14, 2020
1c03362
doc: explain `hex` encoding in Buffer API
HarshithaKP Jan 14, 2020
e849b15
deps,test: update to uvwasi 0.0.4
cjihrig Jan 15, 2020
cadab5b
deps: port uvwasi@676ba9a to gyp
cjihrig Jan 15, 2020
dbe7ede
deps: uvwasi: cherry-pick 941bedf
cjihrig Jan 17, 2020
44fafa6
doc: correct added version for --abort-on-uncaught-exception
addaleax Jan 14, 2020
2d8afb9
test: export public symbols in addons tests
bnoordhuis Jan 12, 2020
36b79cd
fs: unset FileHandle fd after close
addaleax Jan 16, 2020
3b4bf94
test: update postmortem test with v12 constants
mmarchini Jan 16, 2020
4b67bb1
src: reduce large pages code duplication
Jan 16, 2020
b809a8c
doc: fix several child_process doc typos
cjihrig Jan 17, 2020
3f1212f
fs: do not emit 'close' twice if emitClose enabled
ronag Jan 16, 2020
a0c2f27
test: add wasi test for symlink() and readlink()
cjihrig Jan 18, 2020
071bbea
doc: document process.std*.fd
HarshithaKP Jan 17, 2020
5d4cd91
test: improve wasi stat test
cjihrig Jan 19, 2020
b8ebb9c
doc: add explanatory to path.resolve description
YakovL Jan 20, 2020
fa691f8
doc: fix syntax in N-API documentation
tniessen Jan 22, 2020
dcace84
errors: make use of "cannot" consistent
tniessen Jan 20, 2020
5607cd4
test: remove bluebird remnants from test fixture
Trott Jan 21, 2020
b5076ff
deps: update to uvwasi 0.0.5
cjihrig Jan 20, 2020
edf7d69
deps: uvwasi: cherry-pick ea73af5
cjihrig Jan 21, 2020
59c7df6
deps: uvwasi: cherry-pick c3bef8e
cjihrig Jan 22, 2020
4ccd7dd
deps: uvwasi: cherry-pick eea4508
cjihrig Jan 22, 2020
6d331b1
test: add wasi test for freopen()
cjihrig Jan 18, 2020
8c3e6d0
tls: simplify errors using ThrowCryptoError
tniessen Jan 21, 2020
ec06d00
benchmark: fix getStringWidth() benchmark
Trott Jan 23, 2020
ddfd1b2
src: add C++-style sprintf utility
addaleax Jan 21, 2020
c226b4a
src: use custom fprintf alike to write errors to stderr
addaleax Jan 21, 2020
1dc0483
doc: fix code display in header glitch
Trott Jan 22, 2020
95583df
test: add tests for main() argument handling
cjihrig Jan 20, 2020
53a3a20
doc: add ronag to collaborators
ronag Jan 24, 2020
62ded87
doc: further fix async iterator example
ronag Jan 15, 2020
c0728a3
util: fix inspection of typed arrays with unusual length
BridgeAR Jan 21, 2020
31e1af6
test: fix test-heapdump-worker
addaleax Jan 24, 2020
7274416
src: reduce code duplication in BootstrapNode
lundibundi Jan 22, 2020
8c25c56
src: define noreturn attribute for windows
lxbndr Jan 22, 2020
d70996b
deps: upgrade to libuv 1.34.2
cjihrig Jan 23, 2020
aeec21d
doc: clean up and streamline vm.md examples
lundibundi Jan 23, 2020
ba31587
doc: enable visual code indication in headers
Trott Jan 24, 2020
4b429db
deps: uvwasi: cherry-pick 7b5b6f9
cjihrig Jan 24, 2020
cfbaffd
buffer: improve fill(number) performance
mscdex Jan 24, 2020
8661fa6
build: build docs in GitHub Actions CI workflow
richardlau Jan 24, 2020
309858c
deps: switch to chromium's zlib implementation
mscdex Jan 6, 2020
75453af
build: fix zlib tarball generation
codebytere Mar 4, 2020
2cd3f1a
fs: bail on permission error in recursive directory creation
bcoe Jan 25, 2020
4967bd0
test: make test-http2-buffersize more correct
addaleax Jan 25, 2020
087ad9c
crypto: improve randomBytes() performance
mscdex Jan 26, 2020
8ecac02
doc: remove redundant properties from headers
XhmikosR Jan 22, 2020
c8d71ca
src: fix debug crash handling null strings
rustyconover Jan 26, 2020
fb1ccd8
buffer: improve concat() performance
mscdex Jan 26, 2020
ce3f3ef
benchmark: use let and const instead of var
dnlup Jan 24, 2020
98708a5
tools: replace deprecated iteritems() for items()
Gioyik Jan 26, 2020
25bb558
doc: change error message testing policy
tniessen Jan 20, 2020
39bdc24
test,benchmark: fix test-benchmark-zlib
Trott Jan 27, 2020
a404806
doc: update collaborator guide citgm instructions
ronag Jan 28, 2020
67cff50
doc: simultaneous blog and email of sec announce
sam-github Jan 23, 2020
01ae5a8
doc: update job reference in COLLABORATOR_GUIDE.md
richardlau Jan 28, 2020
f640a54
worker: remove redundant closing of child port
aaccttrr Jan 28, 2020
cf99b75
doc: clarify that `v8.serialize()` is not deterministic
addaleax Jan 28, 2020
ac5845a
n-api: rename 'promise' parameter to 'value'
tniessen Jan 28, 2020
ee1ceb6
doc: add protocol option in http2.connect()
murgatroid99 Jan 29, 2020
634815d
deps: upgrade npm to 6.13.7
Jan 28, 2020
c5616fb
doc: clarify require() OS independence
lundibundi Jan 29, 2020
20b16b2
src: remove preview for heap dump utilities
addaleax Jan 29, 2020
d120eba
build: ignore all the "Debug","Release" folders
ConorDavenport Jan 29, 2020
4cbeba9
test: remove --experimental-worker flag comment
HarshithaKP Jan 29, 2020
70d586f
benchmark: add MessagePort benchmark
addaleax Jan 29, 2020
f01e611
doc: clarify socket.setNoDelay() explanation
rustyconover Jan 27, 2020
1f81e29
doc: fix numbering
Nef10 Jan 30, 2020
8997ee7
test: mark additional tests as flaky on Windows
addaleax Feb 1, 2020
f600eb2
src: fix console debug output on Windows
lundibundi Jan 30, 2020
03eedd8
src: remove duplicate field env in CryptoJob class
ConorDavenport Jan 28, 2020
9a86ba0
test: simplify test-https-simple.js
sam-github May 29, 2019
0d9db1a
benchmark: clean up config resolution in multiple benchmarks
lundibundi Jan 30, 2020
609a7f3
src: change Fill() to use ParseArrayIndex()
ConorDavenport Jan 30, 2020
0641b19
test: unset NODE_OPTIONS for cctest
addaleax Jan 31, 2020
7a88f7e
fs: set path when mkdir recursive called on file
bcoe Feb 2, 2020
250479a
net: track state of setNoDelay() and prevent unnecessary system calls
rustyconover Jan 28, 2020
ae9ea95
src: remove unused `Worker::child_port_` member
addaleax Feb 1, 2020
523442d
src: fix inspecting `MessagePort` from `init` async hook
addaleax Feb 1, 2020
c90d957
doc: add example to fs.promises.readdir
conoro Jan 28, 2020
73c0986
doc: ask more questions in the bug report template
joyeecheung Feb 2, 2020
8a6c09a
meta: fix collaborator list errors in README.md
jasnell Feb 6, 2020
73fb133
test: fix flaky test-http2-stream-destroy-event-order
addaleax Feb 1, 2020
71c1858
doc,assert: rename "mode" to "assertion mode"
Trott Feb 4, 2020
63bb634
n-api: free instance data as reference
Feb 4, 2020
bde485e
test: add test-dns-promises-lookupService
Trott Feb 4, 2020
be3f622
doc: correct getting an ArrayBuffer's length
tsabolov Feb 4, 2020
44235db
doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder
joyeecheung Feb 6, 2020
bf57415
doc: update TSC name in "Release Process"
tniessen Feb 5, 2020
190f0fd
src: various minor improvements to node_url
jasnell Feb 5, 2020
9b0249a
doc: clarify Worker exit/message event ordering
addaleax Feb 5, 2020
b5d56f1
src: fix OOB reads in process.title getter
bnoordhuis Feb 4, 2020
a567b09
src: remove fixed-size GetHumanReadableProcessName
bnoordhuis Feb 4, 2020
e77597c
test: fix flaky test-inspector-connect-main-thread
addaleax Feb 4, 2020
7670333
test: fix test-benchmark-http
Trott Feb 7, 2020
540853c
worker: reset `Isolate` stack limit after entering `Locker`
addaleax Jan 31, 2020
c3024ad
src: remove dead code in InternalMakeCallback
Flarna Feb 3, 2020
64973e9
doc: simplify async_hooks overview
Trott Feb 6, 2020
a2e860f
build: add configure option to debug only Node.js part of the binary
addaleax Feb 5, 2020
fb3b4f3
src: modernized unique_ptr construction
Feb 5, 2020
ecdb961
doc: consolidate introductory text
Trott Feb 6, 2020
00f8569
benchmark: check for and fix multiple end()
mscdex Feb 3, 2020
fc97aa5
benchmark: refactor helper into a class
BridgeAR Jan 16, 2020
9e6d3c4
benchmark: remove special test entries
BridgeAR Jan 20, 2020
cc11467
assert: align character indicators properly
BridgeAR Jan 20, 2020
b9399e7
test: stricter assert color test
BridgeAR Jan 20, 2020
e6f9547
tty: do not end in an infinite warning recursion
BridgeAR Jan 20, 2020
8fd84fc
test,dns: add coverage for dns exception
Trott Feb 7, 2020
cbe9484
doc,net: reword Unix domain path paragraph in net.md
Trott Feb 7, 2020
63ad830
doc,util: revise util.md introductory paragraph
Trott Feb 7, 2020
46e8b91
src: fix compile warnings in node_url.cc
addaleax Feb 7, 2020
f03738f
test: improve assertion message in test-dns-any
Trott Feb 8, 2020
4b5fc33
test: add debugging output to test-net-listen-after-destroy-stdin
Trott Feb 8, 2020
74686bf
test: fix flaky test-fs-stat-bigint
duncanhealy Nov 12, 2019
c2be2ba
test: remove flaky designation for test-fs-stat-bigint
Trott Feb 9, 2020
603f786
doc: improve strict assertion mode color text
Trott Feb 9, 2020
f71328d
doc: revise deepEqual() legacy assertion mode text
Trott Feb 9, 2020
4043ae6
util: throw if unreachable code is reached
Trott Feb 9, 2020
3f87d03
doc: reword section title in addons.md
Trott Feb 10, 2020
fce030d
doc: reword possessive form of Node.js in repl.md
Trott Feb 10, 2020
1f47186
doc: reword possessive form of Node.js in modules.md
Trott Feb 10, 2020
8db24e1
doc: reword possessive form of Node.js in zlib.md
Trott Feb 10, 2020
d9b7290
tools: update Markdown linter to be cross-platform
DerekNonGeneric Jan 20, 2020
c125d46
src: allow to reuse env options handling
lundibundi Feb 9, 2020
ad4d60c
worker: properly handle env and NODE_OPTIONS in workers
lundibundi Feb 9, 2020
7d2fe7d
src: add ExclusiveAccess class
bnoordhuis Feb 13, 2020
a686550
src: wrap HostPort in ExclusiveAccess
bnoordhuis Feb 13, 2020
04a2f71
util: add coverage for util.inspect.colors alias setter
Trott Feb 11, 2020
94caadd
util: throw if unreachable TypedArray checking code is reached
Trott Feb 11, 2020
d8b2602
meta: move calvinmetcalf to emeritus
Trott Feb 11, 2020
abea43e
meta: move vkurchatkin to emeritus
Trott Feb 11, 2020
04bf5bf
meta: move princejwesley to emeritus
Trott Feb 11, 2020
27fe145
doc: update foundation name in onboarding
tniessen Feb 10, 2020
77fccbf
doc: expand C++ README with information about exception handling
addaleax Feb 10, 2020
3a59805
doc: add directions to mark a release line as lts
Feb 10, 2020
f4796ea
test: improve test-fs-stat-bigint
Trott Feb 11, 2020
f6f32f6
doc: fix default server timeout description for https
puzpuzpuz Feb 8, 2020
cfb8fe9
doc: update contact email for @ryzokuken
ryzokuken Feb 7, 2020
54db3dc
doc: fix typo on fs docs
juanarbol Feb 3, 2020
26d2145
worker: add support for .cjs extension
aduh95 Feb 6, 2020
c76cd36
doc: add prerequisites information for Arch
ryzokuken Feb 7, 2020
8e971ab
benchmark: swap var for let in benchmarks
RamirezAlex Jul 31, 2019
5bcd73f
benchmark: use let instead of var
dnlup Jan 31, 2020
b05b04f
crypto: fix performance regression
ronag Feb 11, 2020
d271cdb
doc: add glossary.md
gengjiawen May 1, 2019
02bfb70
test: mark test-fs-stat-bigint flaky on FreeBSD
Trott Feb 11, 2020
2eb92ea
src: use hex not decimal in IsArrayIndex
codebytere Feb 12, 2020
df2355f
doc: guide - using valgrind to debug memory leaks
mhdawson Jan 24, 2020
a998c16
src: prefer 3-argument Array::New()
addaleax Feb 13, 2020
ad55e63
worker: unroll file extension regexp
addaleax Feb 13, 2020
7e872ad
doc: fix typos in doc/api/https.md
Jeff-Tian Feb 14, 2020
250da32
doc: move @Fishrock123 to a previous releaser
Fishrock123 Feb 10, 2020
a069172
doc: move @Fishrock123 to TSC Emeriti
Fishrock123 Feb 10, 2020
17f962a
doc: pronouns for @Fishrock123
Fishrock123 Feb 10, 2020
5277cd0
doc: move gireeshpunathil to TSC emeritus
gireeshpunathil Feb 13, 2020
f99d4c8
test: add known issue test for sync writable callback
jasnell Feb 12, 2020
6bc4fb5
doc: reword possessive form of Node.js in debugger.md
Trott Feb 12, 2020
aaab150
doc: reword possessive form of Node.js in process.md
Trott Feb 12, 2020
fd20217
doc: reword possessive form of Node.js in http.md
Trott Feb 12, 2020
e43a7f7
doc: reword possessive form of Node.js in adding-new-napi-api.md
Trott Feb 12, 2020
850db8c
test: remove common.PORT from test-net-timeout
Trott Feb 12, 2020
538db82
test: remove common.PORT from test-net-throttle
Trott Feb 12, 2020
30ec180
test: remove common.PORT from test-tls-server-large-request
Trott Feb 12, 2020
b702c14
test: remove common.PORT from test-net-pause
Trott Feb 12, 2020
6aca5f9
http2: make compat finished match http/1
ronag Nov 13, 2018
59c75e5
meta: move eljefedelrodeodeljefe to emeritus
Trott Feb 11, 2020
c3801f0
doc: remove reverse-i-search link
puzpuzpuz Mar 15, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
23 changes: 0 additions & 23 deletions .github/ISSUE_TEMPLATE.md

This file was deleted.

41 changes: 34 additions & 7 deletions .github/ISSUE_TEMPLATE/1-bug-report.md
Expand Up @@ -5,20 +5,47 @@ about: Create a report to help us improve
---

<!--
Thank you for reporting a possible bug in Node.js.
Thank you for reporting an issue.
Please fill in as much of the template below as you can.
This issue tracker is for bugs and issues found within Node.js core.
If you require more general support please file an issue on our help
repo. https://github.com/nodejs/help
Please fill in as much of the template below as you're able.
Version: output of `node -v`
Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
Subsystem: if known, please specify the affected core module name
If possible, please provide code that demonstrates the problem, keeping it as
simple and free of external dependencies as you can.
Subsystem: if known, please specify affected core module name
-->

* **Version**:
* **Platform**:
* **Subsystem**:

<!-- Please provide more details below this comment. -->
### What steps will reproduce the bug?

<!--
Enter details about your bug, preferably a simple code snippet that can be
run using `node` directly without installing third-party dependencies.
-->

### How often does it reproduce? Is there a required condition?

### What is the expected behavior?

<!--
If possible please provide textual output instead of screenshots.
-->

### What do you see instead?

<!--
If possible please provide textual output instead of screenshots.
-->

### Additional information

<!--
Tell us anything else you think we should know.
-->
77 changes: 77 additions & 0 deletions .github/workflows/CI.yml
@@ -0,0 +1,77 @@
name: CI

on: [push, pull_request]

jobs:
build-docs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Build
run: NODE=$(which node) make doc-only
- uses: actions/upload-artifact@v1
with:
name: docs
path: out/doc
build-linux:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Environment Information
run: npx envinfo
- name: Build
run: ./configure && make -j2
build-windows:
runs-on: windows-latest
steps:
- uses: actions/checkout@v2
- name: Environment Information
run: npx envinfo
- name: Install deps
run: choco install nasm
- name: Build
run: ./vcbuild.bat
build-macOS:
runs-on: macos-latest
steps:
- uses: actions/checkout@v2
- name: Environment Information
run: npx envinfo
- name: Build
run: ./configure && make -j8
lint-addon-docs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 10
uses: actions/setup-node@v1
with:
node-version: 10.x
- name: Lint addon docs
run: NODE=$(which node) make lint-addon-docs
lint-cpp:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Lint C/C++ files
run: make lint-cpp
lint-md:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 10
uses: actions/setup-node@v1
with:
node-version: 10.x
- name: Lint docs
run: NODE=$(which node) make lint-md
lint-js:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 10
uses: actions/setup-node@v1
with:
node-version: 10.x
- name: Lint JavaScript files
run: NODE=$(which node) make lint-js
33 changes: 33 additions & 0 deletions .github/workflows/pythonpackage.yml
@@ -0,0 +1,33 @@
name: Python 3 testing

on: [push, pull_request]

jobs:
build:
runs-on: ubuntu-latest
strategy:
fail-fast: false
max-parallel: 1
matrix:
python-version: [3.8] # [2.7, 3.5, 3.6, 3.7]
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v1
with:
python-version: ${{ matrix.python-version }}
- name: Compile Node.js
run: |
python ./configure.py
make -j2 V=1
- name: Test JS Suites
run: |
python tools/test.py -j 2 -p dots --report --mode=release --flaky-tests=dontcare default
- name: Test C++ Suites
run: |
make -j1 V=1 test/addons/.buildstamp test/js-native-api/.buildstamp test/node-api/.buildstamp
python tools/test.py -j 2 -p dots --report --mode=release --flaky-tests=dontcare addons js-native-api node-api
- name: Make lint
run: |
make lint-py-build || true
NODE=$(which node) make lint lint-py
4 changes: 2 additions & 2 deletions .gitignore
Expand Up @@ -45,8 +45,8 @@
/config_fips.gypi

# === Rules for MSVS artifacts ===
/Debug
/Release
Debug/
Release/
*.sln
*.suo
*.vcxproj*
Expand Down
1 change: 1 addition & 0 deletions BUILDING.md
Expand Up @@ -249,6 +249,7 @@ Installation via Linux package manager can be achieved with:
* Fedora: `sudo dnf install python gcc-c++ make`
* CentOS and RHEL: `sudo yum install python gcc-c++ make`
* OpenSUSE: `sudo zypper install python gcc-c++ make`
* Arch Linux, Manjaro: `sudo pacman -S python gcc make`

FreeBSD and OpenBSD users may also need to install `libexecinfo`.

Expand Down
34 changes: 27 additions & 7 deletions COLLABORATOR_GUIDE.md
Expand Up @@ -13,6 +13,7 @@
* [Waiting for Approvals](#waiting-for-approvals)
* [Testing and CI](#testing-and-ci)
* [Useful CI Jobs](#useful-ci-jobs)
* [Starting a CI Job](#starting-a-ci-job)
* [Internal vs. Public API](#internal-vs-public-api)
* [Breaking Changes](#breaking-changes)
* [Breaking Changes and Deprecations](#breaking-changes-and-deprecations)
Expand Down Expand Up @@ -191,12 +192,6 @@ everything else. Start a fresh CI if more than seven days have elapsed since
the original failing CI as the compiled binaries for the Windows and ARM
platforms are only kept for seven days.

Some of the CI Jobs may require `GIT_REMOTE_REF` which is the remote portion
of Git refspec. To specify the branch this way `refs/heads/BRANCH` is used
(i.e for `master` -> `refs/heads/master`).
For pull requests it will look like `refs/pull/PR_NUMBER/head`
(i.e. for PR#42 -> `refs/pull/42/head`).

#### Useful CI Jobs

* [`node-test-pull-request`](https://ci.nodejs.org/job/node-test-pull-request/)
Expand All @@ -216,12 +211,37 @@ that the tests are reliable.
runs the standard V8 tests. Run it when updating V8 in Node.js or floating new
patches on V8.

* [`node-test-commit-custom-suites`](https://ci.nodejs.org/job/node-test-commit-custom-suites/)
* [`node-test-commit-custom-suites-freestyle`](https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/)
enables customization of test suites and parameters. It can execute test suites
not used in other CI test runs (such as tests in the `internet` or `pummel`
directories). It can also make sure tests pass when provided with a flag not
used in other CI test runs (such as `--worker`).

#### Starting a CI Job

From the CI Job page, click "Build with Parameters" on the left side.

You generally need to enter only one or both of the following options
in the form:

* `GIT_REMOTE_REF`: Change to the remote portion of git refspec.
To specify the branch this way, `refs/heads/BRANCH` is used
(e.g. for `master` -> `refs/heads/master`).
For pull requests, it will look like `refs/pull/PR_NUMBER/head`
(e.g. for PR#42 -> `refs/pull/42/head`).
* `REBASE_ONTO`: Change that to `origin/master` so the pull request gets rebased
onto master. This can especially be important for pull requests that have been
open a while.

Look at the list of jobs on the left hand side under "Build History" and copy
the link to the one you started (which will be the one on top, but click
through to make sure it says something like "Started 5 seconds ago"
(top right) and "Started by user ...".

Copy/paste the URL for the job into a comment in the pull request.
[`node-test-pull-request`](https://ci.nodejs.org/job/node-test-pull-request/)
is an exception where the GitHub bot will automatically post for you.

### Internal vs. Public API

All functionality in the official Node.js documentation is part of the public
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Expand Up @@ -1032,7 +1032,6 @@ $(TARBALL): release-only $(NODE_EXE) doc
$(RM) -r $(TARNAME)/deps/v8/samples
$(RM) -r $(TARNAME)/deps/v8/tools/profviz
$(RM) -r $(TARNAME)/deps/v8/tools/run-tests.py
$(RM) -r $(TARNAME)/deps/zlib/contrib # too big, unused
$(RM) -r $(TARNAME)/doc/images # too big
$(RM) -r $(TARNAME)/test*.tap
$(RM) -r $(TARNAME)/tools/cpplint.py
Expand All @@ -1043,6 +1042,7 @@ $(TARBALL): release-only $(NODE_EXE) doc
$(RM) -r $(TARNAME)/tools/osx-pkg.pmdoc
find $(TARNAME)/deps/v8/test/* -type d ! -regex '.*/test/torque$$' | xargs $(RM) -r
find $(TARNAME)/deps/v8/test -type f ! -regex '.*/test/torque/.*' | xargs $(RM)
find $(TARNAME)/deps/zlib/contrib/* -type d ! -regex '.*/contrib/optimizations$$' | xargs $(RM) -r
find $(TARNAME)/ -name ".eslint*" -maxdepth 2 | xargs $(RM)
find $(TARNAME)/ -type l | xargs $(RM) # annoying on windows
tar -cf $(TARNAME).tar $(TARNAME)
Expand Down