Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: Fix extra includes of "env.h" and "env-inl.h" in this directory. #32293

Closed
wants to merge 3 commits into from
Closed

src: Fix extra includes of "env.h" and "env-inl.h" in this directory. #32293

wants to merge 3 commits into from

Commits on Mar 16, 2020

  1. src: fix extra includes of "env.h" and "env-inl.h" 

    Due to how the Environment class is used throughout the codebase, there
are a log of includes referencing eitehr env.h or env-inl.h.

This commit cleans up the remaining extra includes of 'env.h' or
'env-inl.h' and adds forward declarations of the Environment class.

PR-URL: nodejs#32293
Refs: nodejs#27531
    @nkreeger
    nkreeger committed Mar 16, 2020
    Copy the full SHA
    3e26be9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into kreeger/include-fixes

    @nkreeger
    nkreeger committed Mar 16, 2020
    Copy the full SHA
    0fbf83b View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2020

  1. Review comments.

    @nkreeger
    nkreeger committed Mar 17, 2020
    Copy the full SHA
    0805001 View commit details
    Browse the repository at this point in the history