Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13.12.0 proposal #32376

Merged
merged 100 commits into from Mar 26, 2020
Merged

v13.12.0 proposal #32376

merged 100 commits into from Mar 26, 2020

Commits on Mar 12, 2020

  1. doc: add missing link for v13.11.0 changelog

    Missing from release, apologies.
    
    PR-URL: #32218
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    MylesBorins committed Mar 12, 2020
    Copy the full SHA
    c72a678 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. meta: move inactive collaborators to emeriti

    I sent an email to inactive collaborators (in the previous 6 months at
    the time, no commits, no PRs reviewed, and no commits landed) asking if
    it was time to move to emeritus.
    
    Some replied affirmatively and I have moved those people to emeritus.
    
    Others replied indicating a desire to remain collaborators, and I left
    them as collaborators.
    
    The remaining folks are being moved to emeritus in this change.
    
    Signed-off-by: Rich Trott <rtrott@gmail.com>
    
    PR-URL: #32151
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Trott authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    397cbca View commit details
    Browse the repository at this point in the history
  2. doc: add Ruben to TSC

    Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
    
    PR-URL: #32213
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mhdawson authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    19fee76 View commit details
    Browse the repository at this point in the history
  3. lib: change var to let/const

    PR-URL: #32037
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    himself65 authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    cd0982a View commit details
    Browse the repository at this point in the history
  4. test: fix test-tls-env-extra-ca-file-load

    Fixes broken unit test for the NODE_EXTRA_CA_CERTS environment
    variable. Unit test was exiting without evaluating any assertions
    or running any tests.
    
    Fixes: #32072
    
    PR-URL: #32073
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ebickle authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    2262e7c View commit details
    Browse the repository at this point in the history
  5. src: refactor to more safe method

    PR-URL: #32087
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    gengjiawen authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    d497f26 View commit details
    Browse the repository at this point in the history
  6. test: buffer.write with longer string scenario

    Make sure longer strings are written up to the buffer end
    
    Refs: #32119
    
    PR-URL: #32123
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    HarshithaKP authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    08edf53 View commit details
    Browse the repository at this point in the history
  7. lib: use spread operator on cluster

    PR-URL: #32125
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    himself65 authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    435341a View commit details
    Browse the repository at this point in the history
  8. build: disable libstdc++ debug containers globally

    Different parts of the debug build were using differently sized
    std::vectors due to `_GLIBCXX_DEBUG` sometimes being defined and
    sometimes not. That ended about as well as you would expect.
    
    Remove the flag.
    
    Fixes: #30056
    
    PR-URL: #30147
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    bnoordhuis authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    2069c4e View commit details
    Browse the repository at this point in the history
  9. util: use a global symbol for util.promisify.custom

    Define `util.promisify.custom`
    as `Symbol.for("nodejs.util.inspect.custom")`, rather than
    as `Symbol("util.inspect.custom")`.
    
    This allows custom `promisify` wrappers to easily/safely be defined
    in non‑Node.js environments.
    
    Fixes: #31647
    
    PR-URL: #31672
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ExE-Boss authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    53fd0d8 View commit details
    Browse the repository at this point in the history
  10. doc: expand fs.watch caveats

    Document Windows specific fs.watch caveats.
    
    Fixes: #31702
    
    PR-URL: #32176
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Masashi Hirano <shisama07@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bzoz authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    5080734 View commit details
    Browse the repository at this point in the history
  11. repl: align preview with the actual executed code

    This adds preview output for input that may not be wrapped.
    
    PR-URL: #32154
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    1ecd407 View commit details
    Browse the repository at this point in the history
  12. test: refactor and simplify test-repl-preview

    Use an object to indicate which part belongs to the input and which
    to the output.
    On top of that this also simplifies the expected output by
    automatically inserting the default repl line for previews and by
    automatically checking for the correct output line length.
    
    PR-URL: #32154
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    BridgeAR authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    ed83a1c View commit details
    Browse the repository at this point in the history
  13. doc: update conditional exports recommendations

    Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
    PR-URL: #32098
    Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    2 people authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    597bcb5 View commit details
    Browse the repository at this point in the history
  14. worker: allow URL in Worker constructor

    The explicit goal is to let users use `import.meta.url` to
    re-load thecurrent module inside a Worker instance.
    
    Fixes: #30780
    PR-URL: #31664
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    aduh95 authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    e83dcde View commit details
    Browse the repository at this point in the history
  15. test: use portable EOL

    The test wanted to cut huge string into 1KB strings,
    for which a new line character was inserted at appropriate
    places. The value is different in Windows (10, 13).
    Make it portable, by making use of os.EOL semantics
    
    Refs: #25988
    
    PR-URL: #32104
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    HarshithaKP authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    c0af3ac View commit details
    Browse the repository at this point in the history
  16. http2: rename counter in mapToHeaders inner loop

    This change is to prevent potential bugs - e.g., someone might
    automatically use the variable `k` instead of `key`, that is used in
    vicinity of this loop.
    Also changed postincrement to preincrement in iteration steps. It is
    probably done by the optimizer anyway, but otherwise it will save an
    opcode each iteration. And it is a good practice.
    
    PR-URL: #32012
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    mkrawczuk authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    d2fea9f View commit details
    Browse the repository at this point in the history
  17. test: add new scenario for async-local storage

    Add a new scenario of multiple clients sharing a single data
    callback function managing their response data through
    AsyncLocalStorage APIs
    
    Refs: #32063
    Refs: #32060
    Refs: #32062 (comment)
    
    Co-authored-by: Gireesh Punathil <gpunathi@in.ibm.com>
    
    PR-URL: #32082
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    HarshithaKP authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    fd80c21 View commit details
    Browse the repository at this point in the history
  18. deps: V8: cherry-pick f9257802c1c0

    Original commit message:
    
        Fix scanner-level error reporting for hashbang
    
        When the file begins with a hashbang, the scanner is in a failed state
        when SkipHashbang() is called. This is usually not an issue but when
        the parser encounters an ILLEGAL token, it will reset the SyntaxError
        location because of it.
    
        Bug: v8:10110
        Change-Id: I1c7344bf5ad20079cff80130c991f3bff4d7e9a8
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1995312
        Reviewed-by: Toon Verwaest <verwaest@chromium.org>
        Commit-Queue: Toon Verwaest <verwaest@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#66038}
    
    Refs: v8/v8@f925780
    Fixes: #31284
    Signed-off-by: Matheus Marchini <mmarchini@netflix.com>
    
    PR-URL: #32180
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    mmarchini authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    ae90bcc View commit details
    Browse the repository at this point in the history
  19. util: text decoding allows SharedArrayBuffer

    PR-URL: #32203
    Fixes: #32199
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    bfarias-godaddy authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    fa1fa31 View commit details
    Browse the repository at this point in the history
  20. esm: port loader code to JS

    There is no reason for this to be in C++. Using JavaScript means that
    the code is more accessible to more developers, which is important
    for any Node.js feature. This also simplifies the code significantly
    in some areas. On the technical side, this potentially also enables
    making some of the file system operations that are involved
    asynchronous.
    
    PR-URL: #32201
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    addaleax authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    3e9012a View commit details
    Browse the repository at this point in the history
  21. test: verify that WASI errors are rethrown

    This commit adds a test to verify that exceptions thrown from a
    WASI application are properly caught and rethrown. This also
    gets the code coverage in lib/wasi.js back to 100%.
    
    PR-URL: #32157
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    09ca76b View commit details
    Browse the repository at this point in the history
  22. deps: upgrade to libuv 1.35.0

    Notable changes:
    
    - The UV_UDP_MMSG_CHUNK UDP flag has been added.
    - Support has been dropped for FreeBSD < 10.
    - The FreeBSD and Linux system call logic has been simplified to assume the
      presence of features covered by libuv's minimum system requirements.
    - Listening on IPC pipes is no longer allowed.
    - Fix iOS and Android builds.
    
    PR-URL: #32204
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    cjihrig authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    bee1261 View commit details
    Browse the repository at this point in the history
  23. tools: update to acorn@7.1.1

    Update acorn to 7.1.1 in the dev dependencies for the markdown linter.
    
    Refs: https://app.snyk.io/vuln/SNYK-JS-ACORN-559469
    Signed-off-by: Rich Trott <rtrott@gmail.com>
    
    PR-URL: #32259
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Trott authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    963ce08 View commit details
    Browse the repository at this point in the history
  24. test: make test-memory-usage predictable

    The current test relies on undeterministic behavior from V8 GC, and on
    newer versions of V8 this test ocasionally fails because that behavior
    changed.  Prevent that from happening using --predictable-gc-schedule.
    If this test fails in the future, it should fail consistently instead of
    ocasionally, which should help debug.
    
    Ref: nodejs/node-v8#144 (comment)
    Signed-off-by: Matheus Marchini <mmarchini@netflix.com>
    
    PR-URL: #32239
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    mmarchini authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    fbcf602 View commit details
    Browse the repository at this point in the history
  25. src: fix warn_unused_result compiler warning

    ../src/node_file.cc:386:7: warning: ignoring return value of
    function declared with 'warn_unused_result'
    attribute [-Wunused-result]
    
    PR-URL: #32241
    Refs: #31972
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    7fc5e6d View commit details
    Browse the repository at this point in the history
  26. test: workaround for V8 8.1 inspector pause issue

    `test-inspector-multisession-ws` and `test-inspector-break-when-eval`
    will be affected by an upstream bug when we upgrade V8 to 8.1. The bug
    is caused when the Inspector sets a pause at the start of a function
    compiled with `CompileFunctionInContext`, but that function hasn't been
    executed yet.
    
    On both tests, this issue is triggered by pausing while in C++ executing
    LookupAndCompile, which is called by requiring internal modules while
    running `console.log`. To eliminate this issue in both tests, we add an
    extra `console.log` to ensure we only pause we required all internal
    modules we need. On `test-inspector-break-when-eval`, we also need to
    start the child process with `--inspect-brk` instead of `--inspect` to
    ensure the test is predictable (this test would occasianlly fail on
    slower machines, when console.log doesn't run fast enough to finish
    after emitting `Runtime.consoleAPICalled` and before the parent process
    sending `Runtime.evaluate` message.
    
    Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10287
    
    PR-URL: #32234
    Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10287
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    mmarchini authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    df1d4f7 View commit details
    Browse the repository at this point in the history
  27. src: find .text section using dl_iterate_phdr

    Use `dl_iterate_phdr(3)` to find the mapping containing
    `__node_text_start` instead of parsing `/proc/self/maps`.
    
    Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Co-Authored-By: Ben Noordhuis <info@bnoordhuis.nl>
    PR-URL: #32244
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    2 people authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    c00ce7b View commit details
    Browse the repository at this point in the history
  28. src: unconditionally include report feature

    This commit removes all #ifdef NODE_REPORT checks in the src
    directory.
    
    PR-URL: #32242
    Fixes: #26293
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    cjihrig authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    1950c08 View commit details
    Browse the repository at this point in the history
  29. build: remove node_report option in node.gyp

    PR-URL: #32242
    Fixes: #26293
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    cjihrig authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    96ad768 View commit details
    Browse the repository at this point in the history
  30. build: make --without-report a no-op

    This commit makes the configure --without-report flag a no-op.
    This commit also updates a test that depends on the report CLI
    flags being conditionally present.
    
    PR-URL: #32242
    Fixes: #26293
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    cjihrig authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    074c3c1 View commit details
    Browse the repository at this point in the history
  31. test: remove common.skipIfReportDisabled()

    The report feature won't ever be disabled moving forward, so
    checking for its existence in the tests is no longer needed.
    
    PR-URL: #32242
    Fixes: #26293
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    cjihrig authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    76781bd View commit details
    Browse the repository at this point in the history
  32. doc,lib,src,test: make --experimental-report a nop

    This commit makes the --experimental-report CLI flag a no-op.
    
    PR-URL: #32242
    Fixes: #26293
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    cjihrig authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    cd388b2 View commit details
    Browse the repository at this point in the history
  33. doc: update stability of report features

    This commit updates the stability documentation for the report
    feature. All diagnostic report APIs are now listed as stable,
    with the exception of report-on-fatalerror, which still has a
    few bugs to work out.
    
    PR-URL: #32242
    Fixes: #26293
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    cjihrig authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    2e1fb2b View commit details
    Browse the repository at this point in the history
  34. n-api: fix comment on expected N-API version

    Remove the comment about the expected version so
    that it does not get out of sync. The code shows
    the expected version anyway.
    
    Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
    
    PR-URL: #32236
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    mhdawson authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    59a21e2 View commit details
    Browse the repository at this point in the history
  35. tools: update minimist@1.2.5

    Update minimist used by lint-md.js to 1.2.5.
    
    Refs: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764
    Signed-off-by: Rich Trott <rtrott@gmail.com>
    
    PR-URL: #32274
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    5adaf10 View commit details
    Browse the repository at this point in the history
  36. src,cli: support compact (one-line) JSON reports

    Multi-line JSON is more human readable, but harder for log aggregators
    to consume, they usually require a log message per line, particularly
    for JSON. Compact output will be consumable by aggregators such as EFK
    (Elastic Search-Fluentd-Kibana), LogDNA, DataDog, etc.
    
    PR-URL: #32254
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    sam-github authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    b5b7bf5 View commit details
    Browse the repository at this point in the history
  37. deps,doc: move openssl maintenance guide to doc

    The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
    move the OpenSSL one there, too.
    
    PR-URL: #32209
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    sam-github authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    11ed1e6 View commit details
    Browse the repository at this point in the history
  38. errors: drop pronouns from ERR_WORKER_PATH message

    This commit drops pronouns from the ERR_WORKER_PATH message,
    and also shortens the text a bit.
    
    PR-URL: #32285
    Refs: #31664
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cjihrig authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    71a2fa2 View commit details
    Browse the repository at this point in the history
  39. src: handle NULL env scenario

    PR-URL: #32230
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    himself65 authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    1476182 View commit details
    Browse the repository at this point in the history
  40. test: use Promise.all() in test-hash-seed

    We have several tests where a number of asynchronous processes need to
    finish before some checks happen. These are done in a number of ways,
    including (as here) using our Countdown testing module. I think
    Promise.all() may be the idiomatic and ergonomic way to go for a lot of
    these tests. Using this one to get feedback on the idea.
    
    PR-URL: #32273
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Trott authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    05fd160 View commit details
    Browse the repository at this point in the history
  41. http: don't emit 'finish' after 'error'

    PR-URL: #32276
    Refs: #28710
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    ronag authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    ef32069 View commit details
    Browse the repository at this point in the history
  42. lib: add option to disable __proto__

    Adds `--disable-proto` CLI option which can be set to `delete` or
    `throw`.
    
    Fixes #31951
    
    PR-URL: #32279
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    devsnek authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    36ba54e View commit details
    Browse the repository at this point in the history
  43. doc: complete n-api version matrix

    We have received feedback indicating that the N-API support matrix as
    present now can be misinterpreted to mean that old versions of N-API
    are no longer supported on newer versions of Node.js. Filling out the
    bottom of the matrix should hopefully make it clear that support for
    such old versions continues.
    
    PR-URL: #32304
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Gabriel Schulhof authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    b875346 View commit details
    Browse the repository at this point in the history
  44. doc: fix some 404 links

    PR-URL: #32200
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    watson authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    d2ce8e9 View commit details
    Browse the repository at this point in the history
  45. tools: fixup icutrim.py use of string and bytes objects

    PR-URL: #31659
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    jmercier-lbi authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    dedd219 View commit details
    Browse the repository at this point in the history
  46. deps: update to uvwasi 0.0.6

    PR-URL: #32309
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    7904ecd View commit details
    Browse the repository at this point in the history
  47. src: clean up stream_base.h and stream-base-inl.h

    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #32307
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    jasnell authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    1c4a112 View commit details
    Browse the repository at this point in the history
  48. doc: update security release process

    PR-URL: #31679
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    sam-github authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    569e555 View commit details
    Browse the repository at this point in the history
  49. src: prefer OnScopeLeave over shared_ptr<void>

    They do the same thing, but OnScopeLeave avoids an extra
    heap allocation and is more explicit about what it does.
    
    PR-URL: #32247
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    addaleax authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    f873d87 View commit details
    Browse the repository at this point in the history
  50. deps: upgrade to c-ares v1.16.0

    Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_0
    
    PR-URL: #32246
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    addaleax authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    3825afe View commit details
    Browse the repository at this point in the history
  51. cli: allow --huge-max-old-generation-size in NODE_OPTIONS

    PR-URL: #32251
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    addaleax authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    79fdc6b View commit details
    Browse the repository at this point in the history
  52. test: uv_tty_init returns EBADF on IBM i

    When TTY initialization failed, uv_tty_init returned EBADF on IBM i
    PASE, rather than EINVAL
    
    PR-URL: #32338
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    dmabupt authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    4d173ea View commit details
    Browse the repository at this point in the history
  53. src: add debug option to report large page stats

    This adds the new option `HUGEPAGES` to `NODE_DEBUG_NATIVE` that
    causes the code responsible for re-mapping to large pages to output
    memory range and page count information to `stderr`.
    
    Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    PR-URL: #32331
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Gabriel Schulhof authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    243d0d4 View commit details
    Browse the repository at this point in the history
  54. build: expand ASAN acronym in configure help

    There is lots of space to expand this not-so-well-known acronym in the
    option usage message.
    
    PR-URL: #32325
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    sam-github authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    8ea5ffc View commit details
    Browse the repository at this point in the history
  55. deps: minor ICU fixes: maint docs/tool, downloader

    - Docs used the word "copy" when it really meant a tool is needed.
    - README-FULL-ICU.txt was generated in binary mode, but it's a
    text file. This breaks on Python3 for maintaining ICU
    - The ICU downloader was broken (also probably python3). It's
    basically dead code since 1a25e90
    landed (full icu in repo), unless someone deleted the deps/icu-small
    directory from their repo.
    
    Co-Authored-By: Christian Clauss <cclauss@me.com>
    PR-URL: #32347
    
    Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    srl295 authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    e16964e View commit details
    Browse the repository at this point in the history
  56. deps: update to ICU 66.1

    - ICU 66.1 http://site.icu-project.org/download/66
    - Unicode 13
    - CLDR 36.1
    - Updated ./LICENSE
    
    PR-URL: #32348
    Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    srl295 authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    2cb9f7a View commit details
    Browse the repository at this point in the history
  57. src: update comment for SetImmediate()

    Refs: #31502 (comment)
    
    PR-URL: #32300
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    11650c6 View commit details
    Browse the repository at this point in the history
  58. src: avoid Isolate::GetCurrent() for platform implementation

    There’s no need to use `Isolate::GetCurrent()`, which is generally
    discouraged, as the `Isolate*` pointer can generally be looked up
    from the per-Isolate platform data structure.
    
    PR-URL: #32269
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    bd55a9a View commit details
    Browse the repository at this point in the history
  59. Revert "build: add asan check in Github action"

    This reverts commit 3ec4b21.
    
    See: #32257
    
    PR-URL: #32324
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    mmarchini authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    85bdb42 View commit details
    Browse the repository at this point in the history
  60. test: replace Map with Array in cluster-net-listen tests

    PR-URL: #32381
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Trott authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    bdcc11f View commit details
    Browse the repository at this point in the history
  61. test: replace countdown with Promise.all() in cluster-net-listen tests

    PR-URL: #32381
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Trott authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    2e28783 View commit details
    Browse the repository at this point in the history
  62. module: add hook for global preload code

    PR-URL: #32068
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    jkrems authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    7356c43 View commit details
    Browse the repository at this point in the history
  63. deps: upgrade openssl sources to 1.1.1e

    This updates all sources in deps/openssl/openssl by:
        $ cd deps/openssl/
        $ rm -rf openssl
        $ tar zxf ~/tmp/openssl-1.1.1e.tar.gz
        $ mv openssl-1.1.1e openssl
        $ git add --all openssl
        $ git commit openssl
    
    PR-URL: #32328
    Fixes: #32210
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    hassaanp authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    3878d8d View commit details
    Browse the repository at this point in the history
  64. deps: adjust openssl configuration for 1.1.1e

    The scripts used by make were modified to correctly reference the source
    files that were originially in crypto/include/internal, but got moved to
    include/crypto.  The base path has been left unaltered since that would
    require too many changes
    
    PR-URL: #32328
    Fixes: #32210
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    hassaanp authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    d719f87 View commit details
    Browse the repository at this point in the history
  65. deps: update archs files for OpenSSL-1.1.1e

    After an OpenSSL source update, all the config files need to be
    regenerated and comitted by:
        $ cd deps/openssl/config
        $ make
        $ git add deps/openssl/config/archs
        $ git add deps/openssl/include
    
    PR-URL: #32328
    Fixes: #32210
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    hassaanp authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    d640426 View commit details
    Browse the repository at this point in the history
  66. test: discard data received by client

    This test was timing out after update to OpenSSL-1.1.1e.
    
    PR-URL: #32328
    Fixes: #32210
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    hassaanp authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    fcf9b46 View commit details
    Browse the repository at this point in the history
  67. test: end tls connection with some data

    In openssl-1.1.1e the client doesn't seem to like having the TLS
    connection shut down with no data sent, so send an empty string. A
    number of related issues showed up in the TLS1.3 port, so this is
    not entirely surprising.
    
    PR-URL: #32328
    Fixes: #32210
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    sam-github authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    76a7386 View commit details
    Browse the repository at this point in the history
  68. src: delete CallbackInfo when cleared from cleanup hook

    Fixes: #32400
    
    PR-URL: #32405
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    2fe351f View commit details
    Browse the repository at this point in the history
  69. src: simplify IsolateData shortcut accesses

    PR-URL: #32407
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    addaleax authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    2bcf535 View commit details
    Browse the repository at this point in the history
  70. src: delete BaseObjectWeakPtr data when pointee is gone

    Fix the condition for deleting the underlying data pointed to by
    a `BaseObjectWeakPtr`, which erroneously skipped that deletion
    when `ptr->get()` was `nullptr`. This fixes a memory leak reported
    by some of the tests.
    
    Refs: #30374 (comment)
    
    PR-URL: #32393
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    addaleax authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    6f06cf0 View commit details
    Browse the repository at this point in the history
  71. test: use mustCall in place of countdown in timers test

    Use common.mustCall() in place of countdown in
    test-timers-immediate-unref.
    
    PR-URL: #32416
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Trott authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    2f73e6e View commit details
    Browse the repository at this point in the history
  72. deps: upgrade npm to 6.14.1

    PR-URL: #31977
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    isaacs authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    fbdc4f5 View commit details
    Browse the repository at this point in the history
  73. deps: update npm to 6.14.3

    PR-URL: #32368
    Refs: #32296
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    MylesBorins committed Mar 24, 2020
    Copy the full SHA
    eef4721 View commit details
    Browse the repository at this point in the history
  74. deps: remove *.pyc files from deps/npm

    These seem to have accidentally slipped into the npm source tarball and
    cause problems when contributors update their git checkout of node.
    
    PR-URL: #32387
    Refs: #32368
    Refs: npm/cli#1037
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    bnoordhuis authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    8201704 View commit details
    Browse the repository at this point in the history
  75. deps: update term-size with signed version

    PR-URL: #31459
    Refs: #29216
    Refs: sindresorhus/macos-terminal-size#3
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
    Signed-off-by: Rod Vagg <rod@vagg.org>
    rvagg authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    6387cf8 View commit details
    Browse the repository at this point in the history
  76. build: macOS package notarization

    Includes hardened-runtime patch from gdams from
    #29216 (comment)
    
    PR-URL: #31459
    Refs: #29216
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
    Signed-off-by: Rod Vagg <rod@vagg.org>
    rvagg authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    f8a020e View commit details
    Browse the repository at this point in the history
  77. doc: official macOS builds now on 10.15 + Xcode 11

    PR-URL: #31459
    Refs: #29216
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
    Signed-off-by: Rod Vagg <rod@vagg.org>
    rvagg authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    99f260f View commit details
    Browse the repository at this point in the history
  78. doc: add note re term-size commit on top of npm

    Until npm updates update-notifier to a newer version, the dependency
    tree will contain a version of term-size that has an unsigned macOS
    binary. This will fail .pkg notarization and will result in failed
    release builds. We built and signed a term-size and contributed it back
    to the project for this purpose, but the dependency chain is long enough
    that it's not likely to be included in a new npm very quickly.
    Until it is, we need to cherry-pick commit d2f08a1 ontop of any npm
    updates to master and any other release branch that includes
    notarization.
    
    PR-URL: #32403
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    rvagg authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    471a5d8 View commit details
    Browse the repository at this point in the history
  79. stream: don't emit 'finish' after 'error'

    Backport-PR-URL: #32372
    PR-URL: #32275
    Refs: #28710
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Backport-PR-URL: #32372
    ronag authored and MylesBorins committed Mar 24, 2020
    Copy the full SHA
    23ba088 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. doc: import clarifications with links to MDN

    PR-URL: #31479
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    aldeed authored and MylesBorins committed Mar 25, 2020
    Copy the full SHA
    4ca3030 View commit details
    Browse the repository at this point in the history
  2. build: annotate markdown lint failures in pull requests

    Add a problem matcher for output from remark-lint to our lint-md GitHub
    Actions CI workflow so that any markdown linter failures are annotated
    in the pull request in the web UI.
    
    Signed-off-by: Richard Lau <riclau@uk.ibm.com>
    
    PR-URL: #32391
    Refs: https://github.com/actions/toolkit/blob/master/docs/problem-matchers.md
    Refs: https://github.com/actions/toolkit/blob/master/docs/commands.md#problem-matchers
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    richardlau authored and MylesBorins committed Mar 25, 2020
    Copy the full SHA
    81183ca View commit details
    Browse the repository at this point in the history
  3. doc: improve wording in esm.md

    Simplify complex sentence. Remove use of "straightforward".
    
    PR-URL: #32427
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Mar 25, 2020
    Copy the full SHA
    bbea3f2 View commit details
    Browse the repository at this point in the history
  4. doc: improve wording in vm.md

    Simplify complex sentence. Remove use of "straightforward".
    
    PR-URL: #32427
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Mar 25, 2020
    Copy the full SHA
    dfcc3e8 View commit details
    Browse the repository at this point in the history
  5. test: refactoring / cleanup on child-process tests

    PR-URL: #32078
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    jasnell authored and MylesBorins committed Mar 25, 2020
    Copy the full SHA
    07e4131 View commit details
    Browse the repository at this point in the history
  6. doc: fix lint warning in doc/api/esm.md

    Signed-off-by: Richard Lau <riclau@uk.ibm.com>
    
    PR-URL: #32462
    Refs: #31479
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    richardlau authored and MylesBorins committed Mar 25, 2020
    Copy the full SHA
    99a7636 View commit details
    Browse the repository at this point in the history
  7. doc: add new TSC members

    Refs: nodejs/TSC#829
    Refs: nodejs/TSC#832
    Refs: nodejs/TSC#831
    
    Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
    
    PR-URL: #32473
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mhdawson authored and MylesBorins committed Mar 25, 2020
    Copy the full SHA
    b5e4adf View commit details
    Browse the repository at this point in the history
  8. stream: add pipeline test for destroy of returned stream

    Adds a test to ensure that destroying the returned stream
    of pipeline will cause a premature close error.
    
    PR-URL: #32425
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    ronag authored and MylesBorins committed Mar 25, 2020
    Copy the full SHA
    0185e3a View commit details
    Browse the repository at this point in the history
  9. stream: fix pipeline with dest in objectMode

    pipeline did not support destination with generator
    that does not return strings or buffers.
    
    PR-URL: #32414
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    ronag authored and MylesBorins committed Mar 25, 2020
    Copy the full SHA
    b7a8878 View commit details
    Browse the repository at this point in the history
  10. report: handle on-fatalerror better

    --report-on-fatalerror was not honored properly, as there was no
    way to check the value which was stored in the Environment pointer
    which can be inaccessible under certain fatal error situations.
    
    Move the flag out of Environment pointer so that this is doable.
    
    Co-authored-by: Shobhit Chittora schittora@paypal.com
    
    PR-URL: #32207
    Fixes: #31576
    Refs: #29881
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    HarshithaKP authored and MylesBorins committed Mar 25, 2020
    Copy the full SHA
    28e298f View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2020

  1. src: use single ObjectTemplate for TextDecoder

    `ObjectTemplate`s are not garbage-collected like regular objects
    (for some reason). It is sufficient to create a single template
    anyway, so do that to address the memory leak.
    
    Fixes: #32424
    
    PR-URL: #32426
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    addaleax authored and MylesBorins committed Mar 26, 2020
    Copy the full SHA
    e9e12b8 View commit details
    Browse the repository at this point in the history
  2. src: enhance C++ sprintf utility

    PR-URL: #32385
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    himself65 authored and MylesBorins committed Mar 26, 2020
    Copy the full SHA
    94952b4 View commit details
    Browse the repository at this point in the history
  3. doc: simplify and correct example descriptions in net.md

    Instead of indicating that examples show lines to change in previous
    examples, present the examples as standalone items. They suffice on
    their own.
    
    In the first of these, it says to change "the second line" of a previous
    example, but if it were literally changed to the provided line, it would
    result in a syntax error.
    
    In the second of these, it gives the wrong line to change.
    
    All of this is unnecessary and probably makes the examples harder to
    follow. So simplify and treat each one as a separate example.
    
    PR-URL: #32451
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and MylesBorins committed Mar 26, 2020
    Copy the full SHA
    6693b40 View commit details
    Browse the repository at this point in the history
  4. doc: update async_hooks.md

    Typo `runAndReturn` -> `runSyncAndReturn`
    
    PR-URL: #32382
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Doc999tor authored and MylesBorins committed Mar 26, 2020
    Copy the full SHA
    3e002c3 View commit details
    Browse the repository at this point in the history
  5. doc: trim wording in n-api.md text about exceptions

    PR-URL: #32457
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Trott authored and MylesBorins committed Mar 26, 2020
    Copy the full SHA
    9fda912 View commit details
    Browse the repository at this point in the history
  6. doc: remove unnecessary "obvious(ly)" modifiers in esm.md

    Remove "obvious" and "obviously" in two places in esm.md. It may be
    obvious to some, but likely not everyone or else it probably wouldn't be
    worth mentioning/documenting.
    
    PR-URL: #32457
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Trott authored and MylesBorins committed Mar 26, 2020
    Copy the full SHA
    6168bd5 View commit details
    Browse the repository at this point in the history
  7. doc: remove extraneous sentence in events.md

    Since the previous sentence describes `10` as a default, and the
    following sentence explains how to modify that default, it is
    unnecessary to explain that "Obviously, not all events should be limited
    to just 10 listeners."
    
    PR-URL: #32457
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Trott authored and MylesBorins committed Mar 26, 2020
    Copy the full SHA
    40a9289 View commit details
    Browse the repository at this point in the history
  8. deps: upgrade npm to 6.14.4

    PR-URL: #32495
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    ruyadorno authored and MylesBorins committed Mar 26, 2020
    Copy the full SHA
    deab08b View commit details
    Browse the repository at this point in the history
  9. stream: emit 'pause' on unpipe

    unpipe should use pause() instead of mutating
    state.flowing directly so that pausing side
    effects such as emitting 'pause' are properly
    performed.
    
    Fixes: #32470
    
    PR-URL: #32476
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    ronag authored and MylesBorins committed Mar 26, 2020
    Copy the full SHA
    56da8df View commit details
    Browse the repository at this point in the history
  10. 2020-03-26 Version 13.12.0 (Current)

    macOS package notarization and a change in builder configuration:
    
    The macOS binaries for this release, and future 13.x releases, are now
    being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
    package notarization, a requirement for installing on .pkg files on
    macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on
    macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being
    compiled to support a minimum of macOS 10.10 (Yosemite) we do not
    anticipate this having a negative impact on Node.js 13.x users with
    older versions of macOS.
    
    Notable changes:
    
    * build:
      * macOS package notarization (Rod Vagg)
        #31459
    * deps:
      * upgrade npm to 6.14.4 (Ruy Adorno)
        #32495
      * update to uvwasi 0.0.6 (Colin Ihrig)
        #32309
      * upgrade to libuv 1.35.0 (Colin Ihrig)
        #32204
    * lib:
      * add --disable-proto option to cli (Gus Caplan)
        #32279
    * node_report:
      * move diagnostic reports to stable (Colin Ihrig)
        #32242
    * worker:
      * allow URL in Worker constructor (Antoine du HAMEL)
        #31664
    * util:
      * use a global symbol for `util.promisify.custom` (ExE Boss)
        #31672
    
    PR-URL: #32376
    MylesBorins committed Mar 26, 2020
    Copy the full SHA
    f6a339f View commit details
    Browse the repository at this point in the history