Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: part 2... ngtcp2 and nghttp3 #32378

Closed
wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 19, 2020

This is the second of three separate PRs that would need to be landed together. They have been split to allow easier reviewing. This PR covers the addition of the ngtcp2 and nghttp3 dependencies to the source tree.

NOTE: This PR merges into the initial-quic-part-1 branch

The other two PRs in this batch are:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@sam-github
Copy link
Contributor

This commit has two .gyp files in it, which are unique to Node.js (and have inconsistent indentation, if that matters).

For maintainability, the commit adding the gyp files that we maintain should be split from the commit adding the upstream maintained source.

The commit adding the upstream src should describe where it came from, and what version of the dep got vendored in (probably just a "curled from this URL (that includes a version), untarred, moved into place" is sufficient if it came from a released tarball.

There should be commit adding a doc/guide/maintaining-ngXXX doc (one? two? as you think reasonable) that describes how to update these deps when they inevitably need updating.

@jasnell
Copy link
Member Author

jasnell commented Mar 20, 2020

Will work those changes in @sam-github thank you :-)

@jasnell
Copy link
Member Author

jasnell commented Mar 24, 2020

Updated to include maintenance instructions

@jasnell jasnell added the review wanted PRs that need reviews. label Mar 29, 2020
@nodejs-github-bot
Copy link
Collaborator

@jasnell
Copy link
Member Author

jasnell commented Mar 31, 2020

Putting all three of the PRs here on the tsc-agenda to queue up discussion on how we want to get these landed.

@jasnell jasnell added tsc-agenda Issues and PRs to discuss during the meetings of the TSC. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Mar 31, 2020
@jasnell jasnell removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Apr 15, 2020
@jasnell
Copy link
Member Author

jasnell commented May 7, 2020

nodejs/quic master was rebased and sync'd with nodejs/master earlier today. The commits in the PR have been updated accordingly.

Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quic Issues and PRs related to the QUIC implementation / HTTP/3. review wanted PRs that need reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants