Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use single ObjectTemplate for TextDecoder #32426

Closed
wants to merge 2 commits into from
Closed

src: use single ObjectTemplate for TextDecoder #32426

wants to merge 2 commits into from

Commits on Mar 22, 2020

  1. src: use single ObjectTemplate for TextDecoder 

    `ObjectTemplate`s are not garbage-collected like regular objects
(for some reason). It is sufficient to create a single template
anyway, so do that to address the memory leak.

Fixes: nodejs#32424
    @addaleax
    addaleax committed Mar 22, 2020
    Copy the full SHA
    9c49e63 View commit details
    Browse the repository at this point in the history

  2. fixup! src: use single ObjectTemplate for TextDecoder

    @addaleax
    addaleax committed Mar 22, 2020
    Copy the full SHA
    97dc8dc View commit details
    Browse the repository at this point in the history