Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: minor worker code cleanups #32562

Closed
wants to merge 2 commits into from
Closed

src: minor worker code cleanups #32562

wants to merge 2 commits into from

Commits on Mar 30, 2020

  1. src: clean up worker thread creation code 

    Instead of setting and then in the case of error un-setting properties,
only set them when no error occurs.

Refs: nodejs#32344
    @addaleax
    addaleax committed Mar 30, 2020
    Copy the full SHA
    09d3469 View commit details
    Browse the repository at this point in the history

  2. src: remove loop_init_failed_ from Worker class 

    There’s no reason for this to not be stored alongside the loop
data structure itself.
    @addaleax
    addaleax committed Mar 30, 2020
    Copy the full SHA
    09003e3 View commit details
    Browse the repository at this point in the history