Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x] deps: revert whitespace changes on V8 #32605

Closed
wants to merge 1 commit into from
Closed

[v12.x] deps: revert whitespace changes on V8 #32605

wants to merge 1 commit into from

Commits on Apr 1, 2020

  1. deps: revert whitespace changes on V8 

    While landing some of the V8 upgrades on the v12 branch, something went
wrong and git made unecessary (and incorrect) whitespace changes to test
fixtures, which broke V8 tests. This was likely caused by the use of
`git node land` or a simiar tool. Revert those changes to fix our tests.
Since this only reverts unwanted changes on deps/v8, and it only affects
tests, don't bump v8_embedder_string.
    @mmarchini
    mmarchini committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    f3b8e1b View commit details
    Browse the repository at this point in the history