Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "embedding: make Stop() stop Workers" #32623

Closed
wants to merge 2 commits into from
Closed

Revert "embedding: make Stop() stop Workers" #32623

wants to merge 2 commits into from

Commits on Apr 2, 2020

  1. Revert "embedding: make Stop() stop Workers" 

    This reverts commit 037ac99.

As flaky CI failures have revealed, this feature was implemented
incorrectly. `stop_sub_worker_contexts()` needs to be called on the
thread on which the `Environment` is currently running, it’s not
thread-safe. The current API requires `Stop()` to be thread-safe,
though.

We could add a new API for this, but unless there’s demand, that’s
probably not necessary as `FreeEnvironment()` will also stop Workers,
which is commonly the next action on an `Environment` instance after
having `Stop()` called on it.

Refs: nodejs#32531
    @addaleax
    addaleax committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    0830b83 View commit details
    Browse the repository at this point in the history

  2. src,test: add regression test for nested Worker termination 

    This adds a regression test for terminating a Worker inside which
another Worker is running.
    @addaleax
    addaleax committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    80d4ba8 View commit details
    Browse the repository at this point in the history