Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: run test-abort-aliased-buffer-overflow #32626

Closed
wants to merge 1 commit into from
Closed

test: run test-abort-aliased-buffer-overflow #32626

wants to merge 1 commit into from

Commits on Apr 3, 2020

  1. test: run test-abort-aliased-buffer-overflow 

    nodejs#31740 added an addon-style test to
`test/abort` that was never run because `test/abort/testcfg.py` uses the
AbortTestConfiguration which inherits from SimpleTestConfiguration which
only finds tests in the root of `test/abort`.

Make AbortTestConfiguration inherit from AddonTestConfiguration and
change AddonTestConfiguration to find the tests in the root of the test
bucket in addition to the subfolders.

Fixup `test-abort-aliased-buffer-overflow` so that it works as intended.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>
    @richardlau
    richardlau committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    388c9b5 View commit details
    Browse the repository at this point in the history