Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: additional note in README(.md) informing users that they may nee… #32654

Conversation

haqer1
Copy link
Contributor

@haqer1 haqer1 commented Apr 4, 2020

…d to import a key used to sign a release & check whether it is a sub-key of a primary key listed in README(.md) (which itself isn't listed in it)...

Additional README.md update

Fixes: #32559

Checklist
Note

This is part 2 to simplify closure of part 1 in PR #32591 (this PR is mutually exclusive with PR #32655)

…d to import a key used to sign a release & check whether it is a sub-key of a primary key listed in README(.md) (which itself isn't listed in it)...

Additional README.md update

Fixes: nodejs#32559
@haqer1
Copy link
Contributor Author

haqer1 commented Apr 4, 2020

Currently, a user would be quite likely inclined to import just a single key seen as used to sign a release.

If it's a sub-key, he/she would need to spend a bit of time to deal with it.[1][2]
I believe, such misuse of time needs to be minimized with 1 or 2 thought-out sentences (which people more familiar with the nuances than a stranger are in a better position to provide to reduce the time spent on this aspect).

P.S.
[1] E.g.,
looking the key up over https leads to a security warning:
key-lookup-over-https-leads-to-warning
[2] Googling can lead to another issue or two, with question(s) why this key isn't listed in the README, like:
#23992 (comment)
[3] I'm a minimalist in such situations, & would be inclined to import a single key rather than 10 (which also involves less network traffic & waiting), so i'd prefer landing of this PR to landing of #32655.

Copy link
Member

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this changed text maintains the original intention of the copy. I prefer where #32655 is going and think this PR can likely be closed

@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:18
@jasnell
Copy link
Member

jasnell commented Jul 3, 2020

Doesn't look like this is going to move forward.

@jasnell jasnell closed this Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
4 participants