Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: additional note in README(.md) informing users that it is advise… #32655

Closed
wants to merge 4 commits into from
Closed

doc: additional note in README(.md) informing users that it is advise… #32655

wants to merge 4 commits into from

Commits on Apr 4, 2020

  1. doc: additional note in README(.md) informing users that it is advise… 

    …d to import the full set of trusted release keys (rather than an individual key)

Additional README.md update

Fixes: nodejs#32559
    @haqer1
    haqer1 committed Apr 4, 2020
    Copy the full SHA
    9bd6618 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2020

  1. doc: apply suggestion from code review 

    This leaves a bit more between the lines, but makes the verbiage shorter.

Co-Authored-By: Rich Trott <rtrott@gmail.com>
    @haqer1 @Trott
    haqer1 and Trott committed Apr 9, 2020
    Copy the full SHA
    2e103ed View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. doc: additional note in README(.md) informing users that it is advise… 

    …d to import the full set of trusted release keys (rather than an individual key) (reconciled with another suggestion from code review)

The OP finds his original suggestion more descriptive & more user-friendly, but prefers to move on since that suggestion is stalled in favor of much shorter verbiage

Co-Authored-By: Myles Borins <mylesborins@google.com>

Fixes: nodejs#32559
    @haqer1
    haqer1 committed Oct 28, 2020
    Copy the full SHA
    945cce5 View commit details
    Browse the repository at this point in the history

  2. doc: additional note in README(.md) informing users that it is advise… 

    …d to import the full set of trusted release keys (rather than an individual key) (reconciled with another suggestion from code review)

The OP finds his original suggestion more descriptive & more user-friendly, but prefers to move on since that suggestion is stalled in favor of much shorter verbiage. This version also splits the line at 80 characters to comply with lint-md.

Co-Authored-By: Myles Borins <mylesborins@google.com>

Fixes: nodejs#32559
    @haqer1
    haqer1 committed Oct 28, 2020
    Copy the full SHA
    69d81a9 View commit details
    Browse the repository at this point in the history