Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: removes unnecessary else statement #32662

Closed
wants to merge 1 commit into from
Closed

lib: removes unnecessary else statement #32662

wants to merge 1 commit into from

Conversation

JesuHrz
Copy link
Contributor

@JesuHrz JesuHrz commented Apr 4, 2020

This PR removes the else statement inside the readFileHandle function since exists a return in the if statement which makes that the else statement unnecessary

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Apr 4, 2020
@lpinca lpinca mentioned this pull request Apr 5, 2020
Closed
2 tasks
jasnell
jasnell reviewed Apr 7, 2020
View reviewed changes
lib/internal/fs/promises.js Outdated
}
return result;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be further simplified to:

  return options.encoding ? result.toString(options.encoding) : result;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jasnell for the feedback, I will make this change right now.

@JesuHrz JesuHrz force-pushed the jesuhrz/removes-unnecesary-else-block branch from 1684504 to 36b9d10 Compare April 7, 2020 00:30
juanarbol
juanarbol approved these changes Apr 18, 2020
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30837/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30838/

@lpinca
Copy link
Member

lpinca commented Apr 19, 2020

Landed in a6a15fe.

lpinca pushed a commit that referenced this pull request Apr 19, 2020
@JesuHrz @lpinca
fs: remove unnecessary else statement
a6a15fe 
PR-URL: #32662
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@lpinca lpinca closed this Apr 19, 2020
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@JesuHrz @BethGriggs
fs: remove unnecessary else statement
03d02d7 
PR-URL: #32662
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@JesuHrz @BridgeAR
fs: remove unnecessary else statement
0b2cff2 
PR-URL: #32662
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
Merged
targos pushed a commit that referenced this pull request Apr 30, 2020
@JesuHrz @targos
fs: remove unnecessary else statement
9c18838 
PR-URL: #32662
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@targos targos mentioned this pull request May 2, 2020
Merged
lpinca added a commit to lpinca/node that referenced this pull request May 15, 2020
@lpinca
tools: enable no-else-return lint rule
af70a1c 
Refs: nodejs#32644
Refs: nodejs#32662
lpinca added a commit that referenced this pull request May 16, 2020
@lpinca
tools: enable no-else-return lint rule
b533fb3 
Refs: #32644
Refs: #32662

PR-URL: #32667
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request May 16, 2020
@lpinca @codebytere
tools: enable no-else-return lint rule
9119344 
Refs: #32644
Refs: #32662

PR-URL: #32667
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@lpinca lpinca mentioned this pull request Jul 9, 2020
Closed
4 tasks
lpinca added a commit to lpinca/node that referenced this pull request Jul 9, 2020
@lpinca
tools: enable no-else-return lint rule
441e6d9 
Refs: nodejs#32644
Refs: nodejs#32662

PR-URL: nodejs#32667
Backport-PR-URL: nodejs#34275
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 13, 2020
@lpinca @codebytere
tools: enable no-else-return lint rule
a131c72 
Refs: #32644
Refs: #32662

PR-URL: #32667
Backport-PR-URL: #34275
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@lpinca @codebytere
tools: enable no-else-return lint rule
248f9af 
Refs: #32644
Refs: #32662

PR-URL: #32667
Backport-PR-URL: #34275
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@juanarbol juanarbol juanarbol approved these changes

@rickyes rickyes rickyes approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@JesuHrz @nodejs-github-bot @lpinca @jasnell @BridgeAR @juanarbol @rickyes