Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: save test file in temporary directory #32670

Closed
wants to merge 1 commit into from
Closed

test: save test file in temporary directory #32670

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Apr 5, 2020

The readv_sync.txt test file is currenly saved in the root directory.
Save it in the dedicated temporary directory.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@lpinca
test: save test file in temporary directory
7558d02 
The readv_sync.txt test file is currenly saved in the root directory.
Save it in the dedicated temporary directory.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 5, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 5, 2020 •
edited by addaleax

CI: https://ci.nodejs.org/job/node-test-pull-request/30450/ (:yellow_heart:)

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 5, 2020
@Trott
Copy link
Member

Trott commented Apr 5, 2020

Should we also remove *.txt from .gitignore? That would have made this more noticeable.

addaleax pushed a commit that referenced this pull request Apr 7, 2020
@lpinca @addaleax
test: save test file in temporary directory
2f53eb4 
The readv_sync.txt test file is currenly saved in the root directory.
Save it in the dedicated temporary directory.

PR-URL: #32670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax
Copy link
Member

addaleax commented Apr 7, 2020

Landed in 2f53eb4

Should we also remove *.txt from .gitignore? That would have made this more noticeable.

@Trott Yeah, I think that makes sense. Feel free to open a PR :)

@addaleax addaleax closed this Apr 7, 2020
@lpinca lpinca deleted the use/tmp-dir branch April 7, 2020 18:56
@Trott Trott mentioned this pull request Apr 7, 2020
Merged
2 tasks
@Trott
Copy link
Member

Trott commented Apr 7, 2020

@Trott Yeah, I think that makes sense. Feel free to open a PR :)

#32710

Trott added a commit to Trott/io.js that referenced this pull request Apr 10, 2020
@Trott
build: remove .txt files from .gitignore
ea4b0bc 
Refs: nodejs#32670 (comment)

PR-URL: nodejs#32710
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
@lpinca @targos
test: save test file in temporary directory
a7a70fa 
The readv_sync.txt test file is currenly saved in the root directory.
Save it in the dedicated temporary directory.

PR-URL: #32670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
@Trott @targos
build: remove .txt files from .gitignore
809d42c 
Refs: #32670 (comment)

PR-URL: #32710
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Apr 13, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@lpinca @BethGriggs
test: save test file in temporary directory
c24f512 
The readv_sync.txt test file is currenly saved in the root directory.
Save it in the dedicated temporary directory.

PR-URL: #32670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@Trott @BethGriggs
build: remove .txt files from .gitignore
f4d595e 
Refs: #32670 (comment)

PR-URL: #32710
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos added backport-blocked-v12.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x labels Apr 22, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@lpinca @targos
test: save test file in temporary directory
37e5f3c 
The readv_sync.txt test file is currenly saved in the root directory.
Save it in the dedicated temporary directory.

PR-URL: nodejs#32670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@Trott @targos
build: remove .txt files from .gitignore
605b882 
Refs: nodejs#32670 (comment)

PR-URL: nodejs#32710
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@lpinca @targos
test: save test file in temporary directory
b3ac840 
The readv_sync.txt test file is currenly saved in the root directory.
Save it in the dedicated temporary directory.

PR-URL: #32670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@Trott @targos
build: remove .txt files from .gitignore
26fee8b 
Refs: #32670 (comment)

PR-URL: #32710
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@lpinca @nodejs-github-bot @Trott @addaleax @jasnell @cjihrig @richardlau @ZYSzys @targos