Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: mark pool ArrayBuffer as untransferable #32759

Closed
wants to merge 2 commits into from
Closed

buffer: mark pool ArrayBuffer as untransferable #32759

wants to merge 2 commits into from

Commits on Apr 10, 2020

  1. buffer: mark pool ArrayBuffer as untransferable 

    This removes a footgun in which users could attempt to transfer the
pooled ArrayBuffer underlying a regular `Buffer`, which would lead to
all `Buffer`s that share the same pool being rendered unusable as well,
and potentially break creation of new pooled `Buffer`s.

This disables this kind of transfer.

Refs: nodejs#32752
    @addaleax
    addaleax committed Apr 10, 2020
    Copy the full SHA
    f3efce9 View commit details
    Browse the repository at this point in the history

  2. fixup! buffer: mark pool ArrayBuffer as untransferable

    @addaleax
    addaleax committed Apr 10, 2020
    Copy the full SHA
    46afefd View commit details
    Browse the repository at this point in the history