Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: mention argument name in type check message #32815

Closed
wants to merge 1 commit into from
Closed

worker: mention argument name in type check message #32815

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Refs: #32745 (comment)

/cc @ZYSzys

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax added dont-land-on-v10.x worker Issues and PRs related to Worker support. labels Apr 13, 2020
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 13, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 13, 2020 •
edited by addaleax

CI: https://ci.nodejs.org/job/node-test-pull-request/30686/ (:heavy_check_mark:)

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 13, 2020
@addaleax
Copy link
Member Author

Landed in d699fdd

@addaleax addaleax closed this Apr 15, 2020
addaleax added a commit that referenced this pull request Apr 15, 2020
@addaleax
worker: mention argument name in type check message
d699fdd 
Refs: #32745 (comment)

PR-URL: #32815
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@addaleax addaleax deleted the messageport-arg-check branch April 15, 2020 14:36
MylesBorins pushed a commit that referenced this pull request Apr 17, 2020
@addaleax @MylesBorins
worker: mention argument name in type check message
7fe6122 
Refs: #32745 (comment)

PR-URL: #32815
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@himself65 himself65 himself65 approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@addaleax @nodejs-github-bot @cjihrig @richardlau @himself65 @ZYSzys