Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-http2-reset-flood flaky on all #32825

Closed
wants to merge 1 commit into from
Closed

test: mark test-http2-reset-flood flaky on all #32825

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

Refs: #29802
Refs: #32595

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 13, 2020
@sam-github sam-github changed the title test: mark test-http2-reset-flood on all platforms test: mark test-http2-reset-flood on all Apr 13, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30699/

@sam-github sam-github changed the title test: mark test-http2-reset-flood on all test: mark test-http2-reset-flood flaky on all Apr 13, 2020
@MylesBorins
Copy link
Member

fast-track?

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 14, 2020
MylesBorins
MylesBorins approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sam-github sam-github mentioned this pull request Apr 14, 2020
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30733/

sam-github added a commit that referenced this pull request Apr 14, 2020
@sam-github
test: mark test-http2-reset-flood flaky on all
a12aedf 
Refs: #29802
Refs: #32595

PR-URL: #32825
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@sam-github
Copy link
Contributor Author

Landed in a12aedf

@sam-github sam-github closed this Apr 14, 2020
@sam-github sam-github deleted the flaky-http2-reset-flood branch April 14, 2020 17:58
MylesBorins pushed a commit that referenced this pull request Apr 17, 2020
@sam-github @MylesBorins
test: mark test-http2-reset-flood flaky on all
4b5658b 
Refs: #29802
Refs: #32595

PR-URL: #32825
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@sam-github @targos
test: mark test-http2-reset-flood flaky on all
41c22a9 
Refs: nodejs#29802
Refs: nodejs#32595

PR-URL: nodejs#32825
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@sam-github @BridgeAR
test: mark test-http2-reset-flood flaky on all
98db564 
Refs: #29802
Refs: #32595

PR-URL: #32825
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
Merged
targos pushed a commit that referenced this pull request Apr 28, 2020
@sam-github @targos
test: mark test-http2-reset-flood flaky on all
44ca479 
Refs: #29802
Refs: #32595

PR-URL: #32825
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@targos targos mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Flarna Flarna Flarna approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sam-github @nodejs-github-bot @MylesBorins @addaleax @cjihrig @Flarna