Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 8.3 #32831

Closed
wants to merge 20 commits into from
Closed

deps: update V8 to 8.3 #32831

wants to merge 20 commits into from

Commits on May 7, 2020

  1. deps: update V8 to 8.3.110.9

    targos committed May 7, 2020
    Configuration menu
    Copy the full SHA
    3e65d54 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d3a430d View commit details
    Browse the repository at this point in the history
  3. src: update NODE_MODULE_VERSION to 84

    Major V8 updates are usually API/ABI incompatible with previous
    versions. This commit adapts NODE_MODULE_VERSION for V8 8.3.
    
    Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
    targos committed May 7, 2020
    Configuration menu
    Copy the full SHA
    715779b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    adac932 View commit details
    Browse the repository at this point in the history
  5. deps: update V8 dtrace & postmortem metadata

    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    cjihrig authored and targos committed May 7, 2020
    Configuration menu
    Copy the full SHA
    4c8ea6e View commit details
    Browse the repository at this point in the history
  6. deps: V8: un-cherry-pick bd019bd

    Original commit message:
    
        [testrunner] delete ancient junit compatible format support
    
        Testrunner has ancient support for JUnit compatible XML output.
    
        This CL removes this old feature.
    
        R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
        CC=​machenbach@chromium.org
    
        Bug: v8:8728
        Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
        Reviewed-on: https://chromium-review.googlesource.com/c/1430065
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
        Commit-Queue: Tamer Tas <tmrts@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#59045}
    
    Refs: v8/v8@bd019bd
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and targos committed May 7, 2020
    Configuration menu
    Copy the full SHA
    62e3cf0 View commit details
    Browse the repository at this point in the history
  7. deps: patch V8 to run on older XCode versions

    Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional
    property, which is a fairly new C++ feature, since that requires a newer
    XCode version than the minimum requirement in BUILDING.md and thus
    breaks CI.
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ryzokuken authored and targos committed May 7, 2020
    Configuration menu
    Copy the full SHA
    3e95ab5 View commit details
    Browse the repository at this point in the history
  8. deps: V8: patch register-arm64.h

    Fixes a compilation issue on some platforms
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and targos committed May 7, 2020
    Configuration menu
    Copy the full SHA
    f8e4ebf View commit details
    Browse the repository at this point in the history
  9. deps: V8: forward declaration of Rtl*FunctionTable

    This should be semver-patch since actual invocation is version
    conditional.
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and targos committed May 7, 2020
    Configuration menu
    Copy the full SHA
    92b1419 View commit details
    Browse the repository at this point in the history
  10. deps: make v8.h compatible with VS2015

    There is a bug in the most recent version of VS2015 that affects v8.h
    and therefore prevents compilation of addons.
    
    Refs: https://stackoverflow.com/q/38378693
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    joaocgreis authored and targos committed May 7, 2020
    Configuration menu
    Copy the full SHA
    b085eb0 View commit details
    Browse the repository at this point in the history
  11. deps: V8: silence irrelevant warnings

    PR-URL: nodejs#26685
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    
    PR-URL: nodejs#32116
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    targos committed May 7, 2020
    Configuration menu
    Copy the full SHA
    e5f7b24 View commit details
    Browse the repository at this point in the history
  12. deps: patch V8 to run on Xcode 8

    Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type
    passed to template call of `OwnedVector::Of`. Xcode 8 can't convert
    'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when
    returning from a function (which is likely a bug on Xcode, considering
    this worked on the prior version of Xcode as well as newer versions).
    This workaround shouldn't affect the application, since the const
    qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_.
    
    There's also a V8 test passing a const-qualified type to ::Of, but since
    we don't test V8 on Xcode 8, it should be fine to leave it as is.
    
    Signed-off-by: Matheus Marchini <mmarchini@netflix.com>
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    mmarchini authored and targos committed May 7, 2020
    Configuration menu
    Copy the full SHA
    59eb0da View commit details
    Browse the repository at this point in the history
  13. deps: fix V8 8.3 on SmartOS

    cjihrig authored and targos committed May 7, 2020
    Configuration menu
    Copy the full SHA
    98fe596 View commit details
    Browse the repository at this point in the history
  14. deps: V8: cherry-pick e1eac1b16c96

    Original commit message:
    
        Fix compilation error with devtoolset-8
    
        We are compiling V8 using devtoolset-8 and it is generating a new
        compilation error related to String Truncation:
    
        error: ‘char* strncpy(char*, const char*, size_t)’ output truncated copying between 1 and 15 bytes from a string of length 15 [-Werror=stringop-truncation]
                  strncpy(buffer, unicode_utf8, i);
    
        Which basically means the null terminating character was not added to
        the end of the buffer:
        https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/
    
        This CL will changes 2 uses of "strncpy" to "memcpy" as strings
        are being copied partially and `\n` being added at a later stage.
    
        Change-Id: I3656afb00463d70ddb8700a487a1978b793e1d09
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2155038
        Reviewed-by: Andreas Haas <ahaas@chromium.org>
        Reviewed-by: Toon Verwaest <verwaest@chromium.org>
        Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
        Cr-Commit-Position: refs/heads/master@{#67277}
    
    Refs: v8/v8@e1eac1b
    
    PR-URL: nodejs#32974
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
    Milad Farazmand authored and targos committed May 7, 2020
    Configuration menu
    Copy the full SHA
    9b7fff6 View commit details
    Browse the repository at this point in the history
  15. deps: V8: cherry-pick 3f8dc4b2e5ba

    Original commit message:
    
        [intl] Remove soon-to-be removed getAllFieldPositions
    
        Needed to land ICU67.1 soon.
    
        Bug: v8:10393
        Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489
        Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
        Commit-Queue: Frank Tang <ftang@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#67027}
    
    Refs: v8/v8@3f8dc4b
    targos committed May 7, 2020
    Configuration menu
    Copy the full SHA
    7c374cf View commit details
    Browse the repository at this point in the history
  16. deps: V8: cherry-pick e29c62b74854

    Original commit message:
    
        [arraybuffer] Clean up BackingStore even if it pointer to nullptr
    
        For a zero-length BackingStore allocation, it is valid for the
        underlying memory to be a null pointer. However, some cleanup
        is still necessary, since the BackingStore may hold a reference
        to the allocator itself, which needs to be released when destroying
        the `BackingStore` instance.
    
        Change-Id: I1f168079d39e4592d2fde31fbe5f705586690e85
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2169646
        Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
        Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#67420}
    
    Refs: v8/v8@e29c62b
    targos committed May 7, 2020
    Configuration menu
    Copy the full SHA
    79217c9 View commit details
    Browse the repository at this point in the history
  17. deps: V8: cherry-pick 74d50c5063b3

    Original commit message:
    
        FreeBSD: add missing include of pthread_np.h
    
        This is necessary for the pthread_attr_get_np function.
    
        Change-Id: I01cfe075a7c86909e8cf37eb7f7c5d44fa044975
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2188310
        Commit-Queue: Michaël Zasso <mic.besace@gmail.com>
        Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
        Auto-Submit: Michaël Zasso <mic.besace@gmail.com>
        Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#67660}
    
    Refs: v8/v8@74d50c5
    targos committed May 7, 2020
    Configuration menu
    Copy the full SHA
    bace24c View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    f423daa View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    b23bfd5 View commit details
    Browse the repository at this point in the history
  20. test: stop testing --interpreted-frames-native-stack for s390x

    V8 does not support the flag on this architecture anymore.
    targos committed May 7, 2020
    Configuration menu
    Copy the full SHA
    3e45653 View commit details
    Browse the repository at this point in the history