Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused CancelPendingDelayedTasks #32859

Closed
wants to merge 1 commit into from
Closed

src: remove unused CancelPendingDelayedTasks #32859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/node.h
View file
Open in desktop
Expand Up @@ -296,11 +296,6 @@ class NODE_EXTERN MultiIsolatePlatform : public v8::Platform {
virtual bool FlushForegroundTasks(v8::Isolate* isolate) = 0;
virtual void DrainTasks(v8::Isolate* isolate) = 0;

// TODO(addaleax): Remove this, it is unnecessary.
// This would currently be called before `UnregisterIsolate()` but will be
// folded into it in the future.
virtual void CancelPendingDelayedTasks(v8::Isolate* isolate);

// This needs to be called between the calls to `Isolate::Allocate()` and
// `Isolate::Initialize()`, so that initialization can already start
// using the platform.
Expand Down
2 changes: 0 additions & 2 deletions src/node_platform.cc
View file
Open in desktop
Expand Up @@ -609,6 +609,4 @@ std::queue<std::unique_ptr<T>> TaskQueue<T>::PopAll() {
return result;
}

void MultiIsolatePlatform::CancelPendingDelayedTasks(Isolate* isolate) {}

} // namespace node