Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove .git folders when testing V8 #32877

Closed
wants to merge 1 commit into from

Commits on Apr 16, 2020

  1. build: remove .git folders when testing V8

    When running `make test-v8` V8's `gclient sync` converts folders
    under `deps/v8/third_party` into git repositories. Unfortunately
    the files that were checked in under `deps/v8/third_party/zlib`
    have been modified from the upstream Chromium repository (some
    files have been deleted and there are whitespace differences in
    some of the files that were kept) so whenever the Node.js source
    tree is hard reset/checked out `gclient sync` notices there are
    unstaged changes as the files in the Node.js source tree do not
    match those of the upstream Chromium third party zlib commit.
    
    Signed-off-by: Richard Lau <riclau@uk.ibm.com>
    richardlau committed Apr 16, 2020
    Copy the full SHA
    484105b View commit details
    Browse the repository at this point in the history