Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add documentation for transferList arg at worker threads #32881

Closed
wants to merge 2 commits into from
Closed

doc: add documentation for transferList arg at worker threads #32881

wants to merge 2 commits into from

Conversation

juanarbol
Copy link
Member

Ref: #32278

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Apr 16, 2020
addaleax
addaleax reviewed Apr 16, 2020
View reviewed changes
doc/api/worker_threads.md Outdated Show resolved Hide resolved
@juanarbol
Copy link
Member Author

juanarbol commented Apr 16, 2020 •
edited

I think this should be landed on version 13 and 14, both releases the feature without the docs.

@juanarbol
Copy link
Member Author

@nodejs/releasers

I think this should be landed on version 13 and 14, both releases the feature without the docs.

i'm a bit scared of adding the labels before any confirmation.

@juanarbol juanarbol added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 26, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30992/

@addaleax
Copy link
Member

Landed in 75e4ccb

@addaleax addaleax closed this Apr 27, 2020
addaleax pushed a commit that referenced this pull request Apr 27, 2020
@juanarbol @addaleax
doc: add documentation for transferList arg at worker threads
75e4ccb 
Ref: #32278

PR-URL: #32881
Refs: #32278
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@juanarbol @BethGriggs
doc: add documentation for transferList arg at worker threads
fdb80f0 
Ref: #32278

PR-URL: #32881
Refs: #32278
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@juanarbol @BridgeAR
doc: add documentation for transferList arg at worker threads
7719f52 
Ref: #32278

PR-URL: #32881
Refs: #32278
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@juanarbol @BridgeAR
doc: add documentation for transferList arg at worker threads
9ebcd79 
Ref: #32278

PR-URL: #32881
Refs: #32278
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@juanarbol @BethGriggs
doc: add documentation for transferList arg at worker threads
26c571a 
Ref: #32278

PR-URL: #32881
Refs: #32278
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@juanarbol @BethGriggs
doc: add documentation for transferList arg at worker threads
a534d82 
Ref: #32278

PR-URL: #32881
Refs: #32278
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Apr 30, 2020
@juanarbol @targos
doc: add documentation for transferList arg at worker threads
ab8ae0f 
Ref: #32278

PR-URL: #32881
Refs: #32278
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request May 2, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@juanarbol @targos
doc: add documentation for transferList arg at worker threads
98c3c42 
Ref: #32278

PR-URL: #32881
Refs: #32278
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@juanarbol juanarbol deleted the juanarbol/add-docs-transferlist branch January 19, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@juanarbol @nodejs-github-bot @addaleax @jasnell @cjihrig @BridgeAR