Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix null deref in AllocatedBuffer::clear #32893

Closed
wants to merge 1 commit into from
Closed

src: fix null deref in AllocatedBuffer::clear #32893

wants to merge 1 commit into from

Conversation

fowles
Copy link
Contributor

@fowles fowles commented Apr 16, 2020

An empty buffer can have a null environment. Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.

Cherry-pick of #32892 to
v12.x branch.

Ref: #32892

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@fowles
src: fix null deref in AllocatedBuffer::clear
41fe422 
An empty buffer can have a null environment.  Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v12.x labels Apr 16, 2020
@fowles
Copy link
Contributor Author

fowles commented Apr 16, 2020

@soldair FYI

@himself65
Copy link
Member

I think you shouldn't pr to v12 branch, only master branch is ok

@addaleax
Copy link
Member

Yes, unless the change only applies to v12.x, PRs go into master first. Unless there is a reason not to, they will be backported to LTS release lines, too. I’ll close this, as #32892 already takes care of everything here.

@addaleax addaleax closed this Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fowles @himself65 @addaleax @nodejs-github-bot