Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix empty-named env var assertion failure #32921

Closed
wants to merge 5 commits into from
Closed

src: fix empty-named env var assertion failure #32921

wants to merge 5 commits into from

Commits on Apr 19, 2020

  1. src: fix empty-named env var assertion failure 

    Setting an environment variable with an empty name on Windows resulted
in an assertion failure, because it was checked for an '=' sign at the
beginning without verifying the length was greater than 0.

Fixes: #32920
Refs: #27310
    @bl-ue
    bl-ue committed Apr 19, 2020
    Copy the full SHA
    15a7f4c View commit details
    Browse the repository at this point in the history

  2. src: relax assertion in operator[] of MaybeStackBuffer 

    Setting environment variables on Windows was causing an abort because
the assertion did not account for the null-terminator at the end of the
buffer.
    @bl-ue
    bl-ue committed Apr 19, 2020
    Copy the full SHA
    afd02b2 View commit details
    Browse the repository at this point in the history

  3. src: do not compare against wide characters

    @bl-ue
    bl-ue committed Apr 19, 2020
    Copy the full SHA
    1017806 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. Revert "src: relax assertion in operator[] of MaybeStackBuffer" 

    This reverts commit afd02b2.
    @bl-ue
    bl-ue committed Apr 20, 2020
    Copy the full SHA
    f181bc8 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2020

  1. src: fix env var empty key access in Worker thread

    @bl-ue
    bl-ue committed Apr 26, 2020
    Copy the full SHA
    446a07a View commit details
    Browse the repository at this point in the history