Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: only write coverage in fully bootstrapped Environments #32960

Closed
wants to merge 1 commit into from

Commits on Apr 21, 2020

  1. inspector: only write coverage in fully bootstrapped Environments

    The NODE_V8_COVERAGE folder and the source map computation are setup
    during pre-execution since they rely on environment variables as well
    as JS states. Therefore, we need to give up serialization of JS coverage
    profiles for Environments that have not go through pre-execution. Currently
    this is only possible for Environments created using the embedder API
    CreateEnvironment().
    
    As a result we won't have JS coverage data for most cctests, but if that
    proves to be necessary we could just run lib/internal/main/environment.js
    for these Environments created for cctests.
    
    Fixes: nodejs#32912
    Refs: nodejs@65e18a8
    Refs: nodejs@5bf4372
    nodejs@8aa7ef7
    joyeecheung committed Apr 21, 2020
    Copy the full SHA
    df4831c View commit details
    Browse the repository at this point in the history