Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: removed unused addressType argument from constructor #32963

Closed
wants to merge 1 commit into from
Closed

cluster: removed unused addressType argument from constructor #32963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 1 addition & 6 deletions lib/internal/cluster/master.js
View file
Open in desktop
Expand Up @@ -297,12 +297,7 @@ function queryServer(worker, message) {
constructor = SharedHandle;
}

handle = new constructor(key,
address,
message.port,
message.addressType,
message.fd,
message.flags);
handle = new constructor(key, address, message);
handles.set(key, handle);
}

Expand Down
2 changes: 1 addition & 1 deletion lib/internal/cluster/round_robin_handle.js
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@ const { constants } = internalBinding('tcp_wrap');

module.exports = RoundRobinHandle;

function RoundRobinHandle(key, address, port, addressType, fd, flags) {
function RoundRobinHandle(key, address, { port, fd, flags }) {
this.key = key;
this.all = new Map();
this.free = new Map();
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/cluster/shared_handle.js
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@ const net = require('net');

module.exports = SharedHandle;

function SharedHandle(key, address, port, addressType, fd, flags) {
function SharedHandle(key, address, { port, addressType, fd, flags }) {
this.key = key;
this.workers = new Map();
this.handle = null;
Expand Down