Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick e1eac1b16c96 #32974

Closed
wants to merge 1 commit into from
Closed

deps: V8: cherry-pick e1eac1b16c96 #32974

wants to merge 1 commit into from

Commits on Apr 21, 2020

  1. deps: V8: cherry-pick e1eac1b16c96

    Original commit message:
    
        Fix compilation error with devtoolset-8
    
        We are compiling V8 using devtoolset-8 and it is generating a new
        compilation error related to String Truncation:
    
        error: ‘char* strncpy(char*, const char*, size_t)’ output truncated copying between 1 and 15 bytes from a string of length 15 [-Werror=stringop-truncation]
                  strncpy(buffer, unicode_utf8, i);
    
        Which basically means the null terminating character was not added to
        the end of the buffer:
        https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/
    
        This CL will changes 2 uses of "strncpy" to "memcpy" as strings
        are being copied partially and `\n` being added at a later stage.
    
        Change-Id: I3656afb00463d70ddb8700a487a1978b793e1d09
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2155038
        Reviewed-by: Andreas Haas <ahaas@chromium.org>
        Reviewed-by: Toon Verwaest <verwaest@chromium.org>
        Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
        Cr-Commit-Position: refs/heads/master@{#67277}
    
    Refs: v8/v8@e1eac1b
    Milad Farazmand committed Apr 21, 2020
    Copy the full SHA
    2b4e123 View commit details
    Browse the repository at this point in the history