Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix invalid windowBits=8 gzip segfault #33045

Closed
wants to merge 5 commits into from
Closed

src: fix invalid windowBits=8 gzip segfault #33045

wants to merge 5 commits into from

Commits on Apr 24, 2020

  1. src: fix invalid windowBits=8 gzip segfault 

    `{ windowBits: 8 }` is legal for deflate streams but not gzip streams.
Fix a nullptr dereference when formatting the error message.

Bug introduced in commit c34eae5 ("zlib: refactor zlib internals")
from September 2018.
    @bnoordhuis
    bnoordhuis committed Apr 24, 2020
    Copy the full SHA
    9436534 View commit details
    Browse the repository at this point in the history

  2. zlib: reject windowBits=8 when mode=GZIP 

    It's also handled in C++ land now, per the previous commit, but
intercepting it in JS land makes for prettier error messages.
    @bnoordhuis
    bnoordhuis committed Apr 24, 2020
    Copy the full SHA
    1cec86e View commit details
    Browse the repository at this point in the history

Commits on May 7, 2020

  1. fixup! zlib: reject windowBits=8 when mode=GZIP

    @addaleax
    addaleax committed May 7, 2020
    Copy the full SHA
    4de03b1 View commit details
    Browse the repository at this point in the history

  2. fixup! src: fix invalid windowBits=8 gzip segfault

    @addaleax
    addaleax committed May 7, 2020
    Copy the full SHA
    40da66d View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. fixup! zlib: reject windowBits=8 when mode=GZIP 

    Co-authored-by: Jiawen Geng <technicalcute@gmail.com>
    @addaleax @gengjiawen
    addaleax and gengjiawen committed May 8, 2020
    Copy the full SHA
    61b08c3 View commit details
    Browse the repository at this point in the history