Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: do not warn when accessing __esModule of unfinished exports #33048

Closed
wants to merge 1 commit into from
Closed

module: do not warn when accessing __esModule of unfinished exports #33048

wants to merge 1 commit into from

Commits on Apr 24, 2020

  1. module: do not warn when accessing __esModule of unfinished exports 

    Since this property access is performed by generated code, and not
used for accessing the actual exports of a module (and because
transpilers generally define it as the first key of `module.exports`
when it *is* present), it should be okay to allow it.

Refs: nodejs#29935
Fixes: nodejs#33046
    @addaleax
    addaleax committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    0b91069 View commit details
    Browse the repository at this point in the history