Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util,readline: NFC-normalize strings before getStringWidth #33052

Closed
wants to merge 1 commit into from
Closed

util,readline: NFC-normalize strings before getStringWidth #33052

wants to merge 1 commit into from

Commits on Apr 25, 2020

  1. util,readline: NFC-normalize strings before getStringWidth 

    The assumption here is that decomposed characters render like their
composed character equivalents, and that working with the former
comes with a risk of over-estimating string widths given that
we compute them on a per-code-point basis. The regression test
added here (한글 vs 한글) is an example of that happening.
    @addaleax
    addaleax committed Apr 25, 2020
    Copy the full SHA
    c533294 View commit details
    Browse the repository at this point in the history