Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip some console tests on dumb terminal #33165

Closed
wants to merge 1 commit into from

Commits on May 4, 2020

  1. test: skip some console tests on dumb terminal

    Add capabilities to common test module to detect and skip tests
    on dumb terminals.
    
    In some of our build environments, like s390x, the terminal
    is a dumb terminal meaning it has very rudimentary capabilities.
    These in turn prevent some of the tests from completing with errors
    as below.
    
        not ok 1777 parallel/test-readline-tab-complete
          ---
          duration_ms: 0.365
          severity: fail
          exitcode: 1
          stack: |-
            assert.js:103
              throw new AssertionError(obj);
              ^
    
            AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
    
            '\t' !== ''
    
                at /home/abuild/rpmbuild/BUILD/node-git.8698dd98bb/test/parallel/test-readline-tab-complete.js:63:14
                at Array.forEach (<anonymous>)
                at /home/abuild/rpmbuild/BUILD/node-git.8698dd98bb/test/parallel/test-readline-tab-complete.js:18:17
                at Array.forEach (<anonymous>)
                at Object.<anonymous> (/home/abuild/rpmbuild/BUILD/node-git.8698dd98bb/test/parallel/test-readline-tab-complete.js:17:3)
                at Module._compile (internal/modules/cjs/loader.js:1176:30)
                at Object.Module._extensions..js (internal/modules/cjs/loader.js:1196:10)
                at Module.load (internal/modules/cjs/loader.js:1040:32)
                at Function.Module._load (internal/modules/cjs/loader.js:929:14)
                at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) {
              generatedMessage: true,
              code: 'ERR_ASSERTION',
              actual: '\t',
              expected: '',
              operator: 'strictEqual'
            }
          ...
    AdamMajer committed May 4, 2020
    Copy the full SHA
    abea223 View commit details
    Browse the repository at this point in the history