Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: 'aborted' IncomingMessage should 'error' #33172

Closed
wants to merge 6 commits into from
Closed

http: 'aborted' IncomingMessage should 'error' #33172

wants to merge 6 commits into from

Commits on May 1, 2020

  1. http: emit 'error' on aborted server request 

    Server requests aka. IncomingMessage emits 'aborted'
instead of 'error' which causes confusion when
the object is used as a regular stream, i.e. if
functions working on streams are passed a
server request object they might not work properly
unless they take this into account.

Refs: nodejs/web-server-frameworks#41
    @ronag
    ronag committed May 1, 2020
    Copy the full SHA
    9515204 View commit details
    Browse the repository at this point in the history

  2. http: emit 'error' on aborted client response 

    Client responses aka. IncomingMessage emits 'aborted'
instead of 'error' which causes confusion when
the object is used as a regular stream, i.e. if
functions working on streams are passed a
client response object they might not work properly
unless they take this into account.

Refs: nodejs/web-server-frameworks#41
Fixes: nodejs#28172
    @ronag
    ronag committed May 1, 2020
    Copy the full SHA
    4bcd762 View commit details
    Browse the repository at this point in the history

  3. fixup! http: emit 'error' on aborted client response

    @ronag
    ronag committed May 1, 2020
    Copy the full SHA
    0c54b5f View commit details
    Browse the repository at this point in the history

Commits on May 3, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
    @ronag @BridgeAR
    ronag and BridgeAR committed May 3, 2020
    Copy the full SHA
    f792724 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. fixup

    @ronag
    ronag committed May 6, 2020
    Copy the full SHA
    49baa70 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2020

  1. fixup

    @ronag
    ronag committed May 9, 2020
    Copy the full SHA
    fb43aa2 View commit details
    Browse the repository at this point in the history