Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for options.fs in fs streams #33185

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
73 changes: 73 additions & 0 deletions test/parallel/test-fs-stream-fs-options.js
@@ -0,0 +1,73 @@
'use strict';

require('../common');
const fixtures = require('../common/fixtures');
const path = require('path');
const fs = require('fs');
const assert = require('assert');

const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

const streamOpts = ['open', 'close'];
const writeStreamOptions = [...streamOpts, 'write'];
const readStreamOptions = [...streamOpts, 'read'];
const originalFs = { fs };

{
const file = path.join(tmpdir.path, 'write-end-test0.txt');

writeStreamOptions.forEach((fn) => {
const overrideFs = Object.assign({}, originalFs.fs, { [fn]: null });
if (fn === 'write') overrideFs.writev = null;

const opts = {
fs: overrideFs
};
assert.throws(
() => fs.createWriteStream(file, opts), {
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError',
message: `The "options.fs.${fn}" property must be of type function. ` +
'Received null'
},
`createWriteStream options.fs.${fn} should throw if isn't a function`
);
});
}

{
const file = path.join(tmpdir.path, 'write-end-test0.txt');
const overrideFs = Object.assign({}, originalFs.fs, { writev: 'not a fn' });
const opts = {
fs: overrideFs
};
assert.throws(
() => fs.createWriteStream(file, opts), {
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError',
message: 'The "options.fs.writev" property must be of type function. ' +
'Received type string (\'not a fn\')'
},
'createWriteStream options.fs.writev should throw if isn\'t a function'
);
}

{
const file = fixtures.path('x.txt');
readStreamOptions.forEach((fn) => {
const overrideFs = Object.assign({}, originalFs.fs, { [fn]: null });
const opts = {
fs: overrideFs
};
assert.throws(
() => fs.createReadStream(file, opts), {
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError',
message: `The "options.fs.${fn}" property must be of type function. ` +
'Received null'
},
`createReadStream options.fs.${fn} should throw if isn't a function`
);
});
}