Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add warning for socket.connect reuse #33204

Closed
wants to merge 4 commits into from
Closed

doc: add warning for socket.connect reuse #33204

wants to merge 4 commits into from

Commits on May 1, 2020

  1. doc: deprecate socket.connect 

    `socket.connect` is subtly broken due to timing and
_undestroy issues. Discourage usage and ask users
to instead create a new socket instance.

Refs: nodejs#33203
    @ronag
    ronag committed May 1, 2020
    Copy the full SHA
    76bf3dd View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Revert "doc: deprecate socket.connect" 

    This reverts commit 76bf3dd.
    @ronag
    ronag committed May 5, 2020
    Copy the full SHA
    3293954 View commit details
    Browse the repository at this point in the history

  2. doc: add warning for socket.connect reuse

    @ronag
    ronag committed May 5, 2020
    Copy the full SHA
    11ae8f4 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. fixup

    @ronag
    ronag committed May 6, 2020
    Copy the full SHA
    74430ce View commit details
    Browse the repository at this point in the history