Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: Reset secureConnecting on client socket #33209

Closed
wants to merge 1 commit into from
Closed

tls: Reset secureConnecting on client socket #33209

wants to merge 1 commit into from

Commits on May 2, 2020

  1. tls: Reset secureConnecting on client socket 

    secureConnecting is never set to false on client TLS sockets.
So if Http2Session constructor (in lib/internal/http2/core.js) is
called after secureConnect is emitted, then it will wrongly wait
for a secureConnect event.

This fix sets secureConnecting to false when a client TLS socket
has connected.
    @davedoesdev
    davedoesdev committed May 2, 2020
    Copy the full SHA
    3c4aa3d View commit details
    Browse the repository at this point in the history