Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix check-imports.py to match on word boundaries #33268

Merged
merged 2 commits into from May 28, 2020
Merged

tools: fix check-imports.py to match on word boundaries #33268

merged 2 commits into from May 28, 2020

Commits on May 28, 2020

  1. src: remove unused using declarations 

    This commit removes the unused using declarations reported by lint-cpp.

PR-URL: nodejs#33268
Refs: nodejs#29226
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    @danbev @richardlau
    danbev authored and richardlau committed May 28, 2020
    Configuration menu
    Copy the full SHA
    4a20cc9 View commit details
    Browse the repository at this point in the history

  2. tools: fix check-imports.py to match on word boundaries 

    `check-imports.py` was missing some unused `using` statements as it
was not matching on word boundaries (e.g. `MaybeLocal` was considered
a use of `Local`). Fix that and add some unit tests (which required
the script to be renamed to drop the `-` so it could be imported into
the test script).

PR-URL: nodejs#33268
Refs: nodejs#29226
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    @richardlau
    richardlau committed May 28, 2020
    Configuration menu
    Copy the full SHA
    05db682 View commit details
    Browse the repository at this point in the history