Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: fixing http_server_for_chunky_client.js #33271

Closed
wants to merge 1 commit into from
Closed

benchmark: fixing http_server_for_chunky_client.js #33271

wants to merge 1 commit into from

Conversation

edsadr
Copy link
Member

@edsadr edsadr commented May 6, 2020

This PR fixes a broken benchmark due to the http header's size restriction introduced earlier

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. labels May 6, 2020
@edsadr
Copy link
Member Author

edsadr commented May 8, 2020

ping @nodejs/benchmarking

@edsadr edsadr requested a review from BridgeAR May 13, 2020 12:47
@BridgeAR
Copy link
Member

@nodejs/http @nodejs/http2 PTAL

mcollina
mcollina approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 19, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31431/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 20, 2020 •
edited by BridgeAR

CI: https://ci.nodejs.org/job/node-test-pull-request/31438/ 💚

@edsadr edsadr self-assigned this May 20, 2020
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 23, 2020
@edsadr @BridgeAR
benchmark: fixing http_server_for_chunky_client.js
6af15eb 
PR-URL: nodejs#33271
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

Landed in 6af15eb 🎉

@BridgeAR BridgeAR closed this May 23, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@edsadr @codebytere
benchmark: fixing http_server_for_chunky_client.js
fb81f1a 
PR-URL: #33271
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@edsadr @codebytere
benchmark: fixing http_server_for_chunky_client.js
26269be 
PR-URL: #33271
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@edsadr @codebytere
benchmark: fixing http_server_for_chunky_client.js
c0534f7 
PR-URL: #33271
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere pushed a commit that referenced this pull request Jul 8, 2020
@edsadr @codebytere
benchmark: fixing http_server_for_chunky_client.js
09277fa 
PR-URL: #33271
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

@edsadr edsadr

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@edsadr @BridgeAR @nodejs-github-bot @mcollina @jasnell @addaleax