url: remove gopher from special schemes #33325

targos · 2020-05-09T14:00:32Z

Refs: #33315
Refs: whatwg/url@d589670
Refs: whatwg/url@7ae1c69

~~Blocked on #33297~~

doc/api/url.md

joyeecheung · 2020-05-11T14:30:34Z

hm, I don't actually know whether this blocks #33297 or that blocks this..I think we could either just see if there is a commit where the test passes with this change (may not exist without fixing other breakage), or just fix them together with the test update?

joyeecheung · 2020-05-11T16:23:51Z

@targos With nodejs/node-core-utils#416 you should be able to update the tests to the last commit that would pass with the gopher changes using git node wpt url --commit=43feb7f612fe9160639e09a47933a29834904d69 (the next test to fix would be web-platform-tests/wpt@5e2d3b3#diff-572d4e421e5e6b9bc11d815e8a027112 BTW)

BridgeAR · 2020-05-23T17:27:35Z

@targos this does not seem to be blocked anymore.

targos · 2020-05-29T08:56:15Z

@mscdex do you feel strongly that this should be semver-major? The spec was changed and browsers updated, so I would like to land this change on all release lines.

Refs: nodejs#33315 Refs: whatwg/url@d589670 Refs: whatwg/url@7ae1c69

nodejs-github-bot · 2020-05-29T15:47:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31628/

jasnell · 2020-05-29T16:58:09Z

Technically it is a breaking change and likely should be major. With tsc hat on, I'd be+1 on making it minor.

@nodejs/tsc ... Other opinions?

targos · 2020-05-31T09:33:25Z

If this is considered semver-major, #33328 should be too.

nodejs-github-bot · 2020-05-31T09:34:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31668/

mhdawson · 2020-06-04T16:02:15Z

As @jasnell mentioned by the rules this should be SemVer major and I don't see/understand a rational for it not being treated that way.

tniessen

LGTM as semver-major

gabrielschulhof · 2020-06-04T20:16:09Z

It does not seem urgent to land this before the next major version.

mhdawson · 2020-06-04T20:23:12Z

From the TSC meeting today:
- Those in the meeting leaning towards leaving as SemVer major unless we come up with a
  strong reason to do otherwise?

nodejs-github-bot · 2020-06-04T20:34:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31727/

jasnell · 2020-06-04T20:34:43Z

I'd say semver-major it is then!

Refs: #33315 Refs: whatwg/url@d589670 Refs: whatwg/url@7ae1c69 PR-URL: #33325 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

targos · 2020-06-06T09:26:31Z

Landed in 0d08d5a

Notable changes: Deprecations and Removals: - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **timers**: introduce timers/promises (James M Snell) (#33950) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) npm 7 (#35631): Node.js 15 comes with a new major release of npm, npm 7. npm 7 comes with many new features - including npm workspaces and a new package-lock.json format. npm 7 also includes yarn.lock file support. One of the big changes in npm 7 is that peer dependencies are now installed by default. Throw On Unhandled Rejections (#33021): As of Node.js 15, the default mode for `unhandledRejection` is changed to `throw` (from `warn`). In `throw` mode, if an `unhandledRejection` hook is not set, the `unhandledRejection` is raised as an uncaught exception. Users that have an `unhandledRejection` hook should see no change in behavior, and it’s still possible to switch modes using the `--unhandled-rejections=mode` process flag. QUIC (#32379): Node.js 15 comes with experimental support QUIC, which can be enabled by compiling Node.js with the `--experimental-quic` configuration flag. The Node.js QUIC implementation is exposed by the core `net` module. V8 8.6 (#35415): The V8 JavaScript engine has been updated to V8 8.6 (V8 8.4 is the latest available in Node.js 14). Along with performance tweaks and improvements the V8 update also brings the following language features: * `Promise.any()` (from V8 8.5) * `AggregateError` (from V8 8.5) * `String.prototype.replaceAll()` (from V8 8.5) * Logical assignment operators `&&=`, `||=`, and `??=` (from V8 8.5) Other Notable Changes: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **dns**: add dns/promises alias (shisama) (#32953) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **stream**: construct (Robert Nagy) (#29656) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) Semver-Major Commits: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **build**: reset embedder string to "-node.0" (Michaël Zasso) (#35415) - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **crypto**: refactoring internals, add WebCrypto (James M Snell) (#35093) - **crypto**: move node\_crypto files to src/crypto (James M Snell) (#35093) - **deps**: V8: cherry-pick d76abfed3512 (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 717543bbf0ef (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 6be2f6e26e8d (Michaël Zasso) (#35415) - **deps**: fix V8 build issue with inline methods (Jiawen Geng) (#35415) - **deps**: fix platform-embedded-file-writer-win for ARM64 (Michaël Zasso) (#35415) - **deps**: update V8 postmortem metadata script (Colin Ihrig) (#35415) - **deps**: update V8 to 8.6.395 (Michaël Zasso) (#35415) - **deps**: upgrade npm to 7.0.0 (Myles Borins) (#35631) - **deps**: update npm to 7.0.0-rc.3 (Myles Borins) (#35474) - **deps**: V8: cherry-pick 0d6debcc5f08 (Gus Caplan) (#33600) - **dns**: add dns/promises alias (shisama) (#32953) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **doc**: update support macos version for 15.x (Ash Cripps) (#35022) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http**: fixed socket.setEncoding fatal error (iskore) (#33405) - **http**: emit 'error' on aborted server request (Robert Nagy) (#33172) - **http**: cleanup end argument handling (Robert Nagy) (#31818) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **http2**: add `invalidheaders` test (Pranshu Srivastava) (#33161) - **http2**: refactor state code validation for the http2Stream class (rickyes) (#33535) - **http2**: header field valid checks (Pranshu Srivastava) (#33193) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: remove ERR\_INVALID\_OPT\_VALUE and ERR\_INVALID\_OPT\_VALUE\_ENCODING (Denys Otrishko) (#34682) - **lib**: handle one of args case in ERR\_MISSING\_ARGS (Denys Otrishko) (#34022) - **lib**: remove NodeError from the prototype of errors with code (Michaël Zasso) (#33857) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: check args in net.connect() and socket.connect() calls (Denys Otrishko) (#34022) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **process**: update v8 fast api calls usage (Maya Lekova) (#35415) - **process**: change default --unhandled-rejections=throw (Dan Fabulich) (#33021) - **process**: use v8 fast api calls for hrtime (Gus Caplan) (#33600) - **process**: delay throwing an error using `throwDeprecation` (Ruben Bridgewater) (#32312) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: implement NodePlatform::PostJob (Clemens Backes) (#35415) - **src**: update NODE\_MODULE\_VERSION to 88 (Michaël Zasso) (#35415) - **src**: error reporting on CPUUsage (Yash Ladha) (#34762) - **src**: use node:moduleName as builtin module filename (Michaël Zasso) (#35498) - **src**: enable wasm trap handler on windows (Gus Caplan) (#35033) - **src**: update NODE\_MODULE\_VERSION to 86 (Michaël Zasso) (#33579) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **src**: remove \_third\_party\_main support (Anna Henningsen) (#33971) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **src**: remove unused CancelPendingDelayedTasks (Anna Henningsen) (#32859) - **stream**: try to wait for flush to complete before 'finish' (Robert Nagy) (#34314) - **stream**: cleanup and fix Readable.wrap (Robert Nagy) (#34204) - **stream**: add promises version to utility functions (rickyes) (#33991) - **stream**: fix writable.end callback behavior (Robert Nagy) (#34101) - **stream**: construct (Robert Nagy) (#29656) - **stream**: write should throw on unknown encoding (Robert Nagy) (#33075) - **stream**: fix \_final and 'prefinish' timing (Robert Nagy) (#32780) - **stream**: simplify Transform stream implementation (Robert Nagy) (#32763) - **stream**: use callback to properly propagate error (Robert Nagy) (#29179) - **test**: update tests after increasing typed array size to 4GB (Kim-Anh Tran) (#35415) - **test**: fix tests for npm 7.0.0 (Myles Borins) (#35631) - **test**: fix test suite to work with npm 7 (Myles Borins) (#35474) - **test**: update WPT harness and tests (Michaël Zasso) (#33770) - **timers**: introduce timers/promises (James M Snell) (#33950) - **tools**: disable x86 safe exception handlers in V8 (Michaël Zasso) (#35415) - **tools**: update V8 gypfiles for 8.6 (Ujjwal Sharma) (#35415) - **tools**: update V8 gypfiles for 8.5 (Ujjwal Sharma) (#35415) - **url**: file URL path normalization (Daijiro Wachi) (#35477) - **url**: verify domain is not empty after "ToASCII" (Michaël Zasso) (#33770) - **url**: remove U+0000 case in the fragment state (Michaël Zasso) (#33770) - **url**: remove gopher from special schemes (Michaël Zasso) (#33325) - **url**: forbid lt and gt in url host code point (Yash Ladha) (#33328) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) - **win, child_process**: sanitize env variables (Bartosz Sosnowski) (#35210) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) - **worker**: set trackUnmanagedFds to true by default (Anna Henningsen) (#34394) - **worker**: rename error code to be more accurate (Anna Henningsen) (#33872) PR-URL: #35014

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 9, 2020

targos mentioned this pull request May 9, 2020

Catch up to recent changes in whatwg/url #33315

Closed

targos added the blocked PRs that are blocked by other issues or PRs. label May 9, 2020

cjihrig approved these changes May 9, 2020

View reviewed changes

targos commented May 9, 2020

View reviewed changes

doc/api/url.md Outdated Show resolved Hide resolved

doc/api/url.md Outdated Show resolved Hide resolved

doc/api/url.md Outdated Show resolved Hide resolved

doc/api/url.md Outdated Show resolved Hide resolved

targos added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label May 9, 2020

mscdex added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 9, 2020

BridgeAR removed the blocked PRs that are blocked by other issues or PRs. label May 23, 2020

BridgeAR approved these changes May 23, 2020

View reviewed changes

jasnell approved these changes May 27, 2020

View reviewed changes

url: remove gopher from special schemes

f163165

Refs: nodejs#33315 Refs: whatwg/url@d589670 Refs: whatwg/url@7ae1c69

targos force-pushed the url-gopher branch from ac1051d to f163165 Compare May 29, 2020 08:57

BridgeAR added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label May 30, 2020

BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:18

mhdawson mentioned this pull request Jun 1, 2020

Node.js Technical Steering Committee (TSC) Meeting 2020-06-04 nodejs/TSC#873

Closed

This was referenced Jun 4, 2020

CI Relability 2020-06-04 JaneaSystems/nodejs-reliability#3

Closed

CI Relability 2020-06-04 JaneaSystems/nodejs-reliability#4

Open

tniessen approved these changes Jun 4, 2020

View reviewed changes

BridgeAR removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Jun 4, 2020

This was referenced Jun 5, 2020

CI Relability 2020-06-05 JaneaSystems/nodejs-reliability#5

Open

CI Relability 2020-06-06 JaneaSystems/nodejs-reliability#6

Open

targos closed this Jun 6, 2020

targos deleted the url-gopher branch June 6, 2020 09:26

This was referenced Jun 7, 2020

CI Relability 2020-06-07 JaneaSystems/nodejs-reliability#7

Open

CI Relability 2020-06-08 JaneaSystems/nodejs-reliability#8

Open

BethGriggs mentioned this pull request Sep 1, 2020

2020-10-20, Version 15.0.0 (Current) #35014

Merged

targos mentioned this pull request Sep 10, 2020

test: update WPT harness #33770

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

url: remove gopher from special schemes #33325

url: remove gopher from special schemes #33325

targos commented May 9, 2020 •

edited

joyeecheung commented May 11, 2020

joyeecheung commented May 11, 2020

BridgeAR commented May 23, 2020

targos commented May 29, 2020

nodejs-github-bot commented May 29, 2020

jasnell commented May 29, 2020

targos commented May 31, 2020

nodejs-github-bot commented May 31, 2020

mhdawson commented Jun 4, 2020

tniessen left a comment

gabrielschulhof commented Jun 4, 2020

mhdawson commented Jun 4, 2020

nodejs-github-bot commented Jun 4, 2020

jasnell commented Jun 4, 2020

targos commented Jun 6, 2020

url: remove gopher from special schemes #33325

url: remove gopher from special schemes #33325

Conversation

targos commented May 9, 2020 • edited

joyeecheung commented May 11, 2020

joyeecheung commented May 11, 2020

BridgeAR commented May 23, 2020

targos commented May 29, 2020

nodejs-github-bot commented May 29, 2020

jasnell commented May 29, 2020

targos commented May 31, 2020

nodejs-github-bot commented May 31, 2020

mhdawson commented Jun 4, 2020

tniessen left a comment

Choose a reason for hiding this comment

gabrielschulhof commented Jun 4, 2020

mhdawson commented Jun 4, 2020

nodejs-github-bot commented Jun 4, 2020

jasnell commented Jun 4, 2020

targos commented Jun 6, 2020

targos commented May 9, 2020 •

edited