doc: update readline key-bindings and TODO comments #33361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation for two key bindings was not correct. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot
added
the
readline
This removes one TODO comment and adds another that indicates that readline is currently not able to trigger specific escape sequences. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
force-pushed
the
minor-adjustments
branch
from
24bec4a
to
63b5734
Compare
|
@nodejs/documentation PTAL |
|
@nodejs/readline @nodejs/documentation this could use some reviews. |
antsmartian
approved these changes
May 18, 2020
BridgeAR
added
the
author ready
|
@BridgeAR I was just going to land this but noticed that the PR description and the commit messages mismatched – I assume the second message is supposed to be |
|
@addaleax yes, that's fine for me. Feel free to change it |
|
Landed in 4c4c226...9de08f7 |
addaleax
pushed a commit
that referenced
this pull request
May 20, 2020
The documentation for two key bindings was not correct. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33361 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
May 20, 2020
This removes one TODO comment and adds another that indicates that readline is currently not able to trigger specific escape sequences. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33361 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
The documentation for two key bindings was not correct. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33361 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
This removes one TODO comment and adds another that indicates that readline is currently not able to trigger specific escape sequences. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33361 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 6, 2020
The documentation for two key bindings was not correct. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33361 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 6, 2020
This removes one TODO comment and adds another that indicates that readline is currently not able to trigger specific escape sequences. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33361 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc: fix readline key binding documentation
The documentation for two key bindings was not correct.
lib: update TODO comments
This removes one TODO comment and adds another that indicates that
readline is currently not able to trigger specific escape sequences.
@nodejs/streams @nodejs/libuv does anyone know why the stream emits
\bin case<ctrl><backspace>or<ctrl><shift><backspace>is used? I would expect it to be a different escape code and I tried to find documentation about it but I failed.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes