Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: fix --tls-keylog option #33366

Closed
wants to merge 1 commit into from

Commits on May 12, 2020

  1. tls: fix --tls-keylog option

    There's a typo that causes only the first socket to be logged
    (i.e. when the warning is emitted).
    
    In addition, server sockets aren't logged because `keylog` events
    are not emitted on tls.Server, not the socket. This behaviour is
    counterintuitive and has caused more bugs in the past, so make all
    sockets (server or client) emit 'keylog'. tls.Server will just
    re-emit these events.
    
    Refs: nodejs#30055
    mildsunrise committed May 12, 2020
    Copy the full SHA
    4f271ad View commit details
    Browse the repository at this point in the history